Repository navigation
[ADD] help_popup_document_page - #128
Merged
Merged
Conversation
Member
Author
|
travis will be green after merging #130 |
Member
|
Really nice @hbrunn thanks a lot for this work. I've done a PR on help_popup OCA/web#417 but it's not yet merged. I have to fix it. Thanks again LGTM, tested, reviewed 👍 |
Member
Author
|
@bealdav the field names change, but apart from that, this should work. Thanks for your review, but please use the github review workflow instead of the old thumbs up |
|
👍 (test) |
gurneyalex
approved these changes
Jun 6, 2019
Member
|
since this is an old PR, could you rebase it to get a fresh CI build? |
hbrunn
force-pushed
the
8.0-help_popup_document_page
branch
from
June 6, 2019 16:06
2acef52 to
ea811f8
Compare
Member
Author
|
yay, somebody looks at my stuff ;-) I squashed commits while being at it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document pages for help
This module knits
document_pageandhelp_popuptogether such that you can write your help texts as document pages. The advantage is that you can use your help texts also as (part of) a functional description of your installation, or the other way around.Installation
To install this module, you need to:
#. install
help_popupfrom thewebrepositoryConfiguration
To configure this module, you need to:
#. add users to the
Documentation writerorAdvanced documentation writergroup#. if you're so inclined, provide a template in the document category
Documentation(added by this module)Usage
Members of the above mentioned groups will have access to the the fields
Documentation forandAdvanced documentation foron a document page if the page's category isDocumentation. In those fields, assign the window action(s) for which the current document page is the (advanced) documentation.Given you can add multiple document pages as help for the same action (they will be concatenated), you can share writing documentation between multiple people writing about different aspects.
@max3903 @bealdav this is my take on #103