Repository navigation
[FIX] ignore exceptions when moving attachment - #129
Merged
pedrobaeza merged 3 commits intoApr 3, 2017
Merged
Conversation
pedrobaeza
approved these changes
Apr 2, 2017
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
The Travis is error is unrelated to this module, but it would be good to be repaired in any moment (it's document_sftp module).
For this one, a little suggestion.
| }, | ||
| context=context) | ||
| except Exception as e: | ||
| logging.exception(e) |
Member
There was a problem hiding this comment.
Better to use parameter exc_info for dumping full stack.
hbrunn
force-pushed
the
8.0-attachments_to_filesystem-guard_exception
branch
from
April 2, 2017 14:13
38e496b to
1f486da
Compare
Member
Author
|
@pedrobaeza thanks, travis is fixed in #130 |
hbrunn
force-pushed
the
8.0-attachments_to_filesystem-guard_exception
branch
from
April 2, 2017 16:08
933b3bf to
4d24e98
Compare
Member
|
Please rebase |
…esystem-guard_exception
Member
Author
|
thanks. The same as making #128 green |
Member
|
Fast-tracked as these are linter PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.