Repository navigation
Merged
Conversation
Member
|
What about Travis? |
|
And maybe a unit test to cover this, seeing as it already bit us in the ass once? |
Author
|
The travis failure is unrelated to this fix. |
pedrobaeza
approved these changes
May 8, 2017
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Well, it was broken before that PR also. Travis is unrelated indeed.
lasley
approved these changes
May 8, 2017
Member
|
tests will be helpful anyways, I only merged this without them because it fixes a problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correction for #135