[bealdav]

Not a really critical module but convenient to document features

cc @gurneyalex @hbrunn @dreispt

[hbrunn]

not sure why you renamed this? i mean, it still pops up help?

please remove all the bullshit comments in code files, they have negative value for readability of the code.

[hbrunn]

support for client actions would be nice, but I see how this is difficult

[bealdav]

Can you explain use cases ? And shouldn't implement it in another module ?

[hbrunn]

ie you want to write a help text for odoo/discuss, then you're out of luck because that's a client action. and there's a tendency to have more and more client actions in Odoo.
I'm not saying you should implement this right away, but I think it's prudent to make it possible in the data model. Comes with baggage of course.

[hbrunn]

it would be nice if this included some javascript that looks for data-* attributes which allow linking to some action in Odoo, as not all actions have paths

[hbrunn]

this still seems like a very useful feature to me

[bealdav]

Thanks @hbrunn for your full review.

I renamed because a popup is inside a tab. In this case this a new window.

But @tonygalmiche suggest me to support a way to embed documentation near chatter place. It seems a good idea with user preference.
But now I really don't know which name must be chosen for this module ;-)

The main purpose of the module, is that the documentation is contextual to the current page. I don't know if we could find a good name with this consideration.

Thanks for any suggestion

I'll answer to all your other requests.

[hbrunn]

the word pop-up was a thing long before there was the concept of browser tabs ;-) but anyways, why not just help? I also liked the name help_online which is abandoned by now.

the exact way of displaying should be something easy to tinker with in other modules/user preferences in any case, as I can imagine ie showing this full screen on mobile, or indeed a popup to move to a second screen can be very useful.

finally, as there's not really anything left of the old module, I'm not sure it makes sense to carry the old commits forward.

[bealdav]

@hbrunn I'll let confirm it'OK before to:

• rename module as help, why not
• make it possible to display help near chatter place
• remove commits from help_module

[bealdav]

Can you explain use cases ? And shouldn't implement it in another module ?

[hbrunn]

* rename module as help, why not
* make it possible to display help near chatter place
* remove commits from help_module

I agree with all of this

[bealdav]

Thanks @hbrunn , I'll also move this code to 20.0 instead of 19.0 because my customer finally go to 20.