Repository navigation
Conversation
… field
The cockpit's per-step thumbnail is skipped when a password field is in the
walk, judged by a role containing "password" (AT-SPI's "password text").
GTK4 reports a PasswordEntry as an unnamed "text box", exactly like an empty
entry, so a GTK4 sign-in window was captured and sent to Beacon
("thumbnail": "sent" on the computer-use rig).
WindowCapture now counts the walk's unnamed text fields, and decide_capture
skips the picture ("password_field") when there is any: GTK4 gives no way to
tell the two apart, and any doubt skips. The capture is built in one module
function, _window_capture(), so the count is tested from SDK-shaped output.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The cockpit's per-step thumbnail is skipped when a password field is in the walk, judged by a role containing "password" (AT-SPI's
password text). GTK4 reports aPasswordEntryas an unnamedtext box, exactly like an empty entry, so a GTK4 sign-in window was captured and its thumbnail sent to Beacon ("thumbnail": "sent"on the test rig).What
WindowCapturecounts the walk's unnamed text fields, anddecide_captureskips the picture (password_field) when there is any: GTK4 gives no way to tell the two apart. The capture is built in one module function,_window_capture(), so the count is tested from SDK-shaped output.Verification
New
tests/test_computer_gtk4_password_thumbnail.py(all red before). Computer-use suites 634 passed; ruff clean. On the rig the same sign-in step then reportedthumbnail: skipped, password_field.🤖 Generated with Claude Code