Skip to content

Fix/coding run config forwarding - #850

Open
sepehrtaji-dev wants to merge 2 commits into
OAraLabs:mainfrom
sepehrtaji-dev:fix/coding-run-config-forwarding
Open

sepehrtaji-dev wants to merge 2 commits into
OAraLabs:mainfrom
sepehrtaji-dev:fix/coding-run-config-forwarding

Conversation

@sepehrtaji-dev

Copy link
Copy Markdown
Contributor

Fix config forwarding for managed coding tasks

Summary

This PR fixes configuration forwarding for managed coding tasks by ensuring that the configured Prometheus config file is passed to the child coding process.

Changes

  • Forward the config path to the coding subprocess.
  • Place the "--config" argument before the "code" subcommand.
  • Inherit the manager's "child_config_path" when no explicit config path is provided.
  • Add a regression test to verify that the config argument is included in the correct position.

Testing

  • Added a regression test in "tests/test_api_code.py".
  • Tests have not been run yet.

Motivation

Managed coding tasks should use the intended configuration instead of unintentionally falling back to default settings. This change helps ensure consistent configuration behavior between the manager and its child coding process.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant