Skip to content

fix(computer): a GTK4 menu button is offered once, as the toggle that acts - #848

Open
OAraLabs wants to merge 1 commit into
mainfrom
fix/computer-gtk4-menu-button-twins
Open

OAraLabs wants to merge 1 commit into
mainfrom
fix/computer-gtk4-menu-button-twins

Conversation

@OAraLabs

Copy link
Copy Markdown
Owner

Why

GTK4 exposes a menu button as a button with no actions wrapping a toggle button of the same name that carries click (GNOME Text Editor's Main menu, Open, View; Files' Current Folder Menu). Both became rows that read alike, so "click the Main menu" tied and the rule chooser abstained: no GTK4 menu button could be clicked by name.

What

A clickable element whose clickable child has the same label is not offered; the child is. Two unrelated buttons of one name still tie, as before.

Verification

New tests/test_computer_gtk4_menu_button_twins.py (2 of 3 red before). Computer-use suites 634 passed; ruff clean. On the rig, "click the Main menu" now opens it (covered by the pick, 459 ms).

🤖 Generated with Claude Code

… acts

GTK4 exposes a menu button as a "button" (no actions) wrapping a "toggle
button" of the same name that carries "click". Both became rows that read
alike, so "click the Main menu" tied and the rule chooser abstained; no GTK4
menu button could be clicked by name. A clickable element whose clickable
child has the same label is now not offered; the child is. Two unrelated
buttons of one name still tie, as before.

Found on the isolated computer-use rig (GNOME Text Editor, Files).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant