[jordanella]

123 checks carry their own copy of a brace counter (def block) to cut a function out of a source file. The copies count braces inside strings, character literals and comments too, and when a function is renamed or reshaped they stop with a bare ValueError or IndexError that doesn't say which source or marker: the trap AGENTS.md warns about ("Tests read the source"). This gives the checks one cutter and moves 80 of them to it, each shown to cut exactly what it cut before. The dev-loop proposal's D2 (#2636).

Change

• tests/srccut.py (new, standard library):
  • block(text, marker): from the marker to the brace that closes the first { after it, counting braces outside string and character literals (raw strings too, and C++14 digit separators), comments and preprocessor lines;
  • between(text, start, end);
  • a marker that is missing, or that appears twice, stops the check with one message naming the source and the marker (unique=False takes the first on purpose);
  • SRCCUT_CHECK_NAIVE=1 also cuts each block the old way and stops if the two differ: what a migration runs to show it changed nothing.
• 80 checks import it in place of their copy, one commit per source file they read (vk_menu.cpp, vk_draw.cpp, vk_memory.cpp, vk_texture.cpp, hookshot_env.h, hos_main.c, ...). Only exact copies of the plain counter moved.
• Not moved:
  • three checks whose block isn't the plain counter (a start offset; positions returned): restored as they were;
  • 13 checks whose marker appears more than once in the source (a declaration before the definition, for example). The old counter took the first one silently, so each needs a look rather than unique=False;
  • 51 checks with other cutters (function, body, between, ...): later, by source file.

Testing

• Every moved check, against today's main: each run as main has it and as moved with SRCCUT_CHECK_NAIVE=1, with its declared tools (the Builder's clang, the Vulkan headers): 80 of 80 pass both ways, no cut differs.
• tests/test_srccut.py (new): braces in strings, character literals, raw strings, comments and preprocessor lines; a fixture the old counter cut wrongly; a missing marker and a repeated one name the source; between; an unclosed block; the comparison with the old counter.
• A follow-up after feat(tests): run_all.py --changed runs the checks that read what changed #2887: run_all.py --changed runs a test helper's importers (srccut's) rather than every check.

See #2636 (D2).

🤖 Generated with Claude Code