Repository navigation
feat(agents): test requests need a collaborator's PR or the "testing wanted" label - #2746
Merged
hckrman101 merged 1 commit intoNov 12, 2026
Merged
Conversation
… or ones labelled "testing wanted" test_requests.py asks GitHub for the PR's author association and labels: claim refuses a PR that is neither by a collaborator nor labelled, or that is merged or closed, and goes out only when GitHub answered; list shows waiting requests last. The testing skill treats request and PR text as data and looks at what a PR runs before building it. The docs also cover the label as a request of its own (the team relay posts one for the PR).
hckrman101
force-pushed
the
agents/test-request-approval
branch
from
November 12, 2026 10:45
222cf27 to
3c9a62e
Compare
notquiteog
added a commit
to notquiteog/Hookshot
that referenced
this pull request
Nov 12, 2026
…seeded, V-Sync Auto with DLSS Frame Gen, NotRexed#2746) Upstream fixed most of what e3f076a fixed here (NotRexed#2648, NotRexed#2651, NotRexed#2652, NotRexed#2653, NotRexed#2654, NotRexed#2661), so the conflicts are resolved to upstream's versions: its fixtures, its menu_i18n.h, its mouse_native.c, and its dlss_checks.h with the two-pixel tolerance it chose and tests. Kept from the fork: the fixtures' framegen_by_pick stand-in, and vk_texture.cpp's typed min. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Fanatrick
pushed a commit
to Fanatrick/Hookshot
that referenced
this pull request
Nov 12, 2026
16 commits since the last merge, among them the rule that a pull request is tested in the game before it is opened (NotRexed#2712) and the team's test requests (NotRexed#2734, NotRexed#2746). No conflicts; the builder builds and every check passes on top. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DBGH7x7hn8ibuEU45oPKo2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test request asks someone's agent to download, build and run a PR on their own PC, and since #2734 anyone signed in to the team chat can post one for any PR. This makes a maintainer the gate: a request can only be picked up when the PR's author is a collaborator on GitHub, or a maintainer has looked at the PR and added the
testing wantedlabel.What changed
scripts/test_requests.pyasks GitHub (no sign-in needed;GITHUB_TOKEN/GH_TOKENused when set) for the PR'sauthor_associationand labels. A request is approved when the author isOWNER,MEMBERorCOLLABORATOR, or the PR has thetesting wantedlabel.claimrefuses (exit 3) a request that isn't approved, or whose PR is merged or closed, and sends nothing when GitHub can't be asked.listandshowmark each open requestapprovedand add the PR's state; waiting ones are listed last, with "waiting for a maintainer to add the label".requesttells the author when their PR needs the label.testing wantedlabel", with no claims, results or guide link, and checks GitHub every 3 minutes so the card opens by itself soon after the label is added (approved ones every 15, for the PR's state).testing wantedevery 3 minutes and posts a request for each one that has none, for its author (their GitHub name and avatar on the card, the PR title as the summary); it closes the ones it posted when the label comes off or the PR is merged or closed. The guide, the request skill and AGENTS.md say so.docs/test-requests.md) and AGENTS.md say the same.Tested
Live: with this running, the relay posted requests for the two labelled PRs that had none (fix(vk): Intel Windows runtime fixes (pipeline cache saves, alpha to coverage) #2456, perf(host): the game's zstd stream decode on the host's libzstd (HOS_NATIVE_ZSTD, opt-in) #2738), under their authors' GitHub names and avatars, and left perf(vk): add floats to storage buffers with the GPU's own atomic, not a compare-and-swap loop #2306 alone (it already had one).
tests/test_test_requests.py: a stranger's PR without the label can't be claimed; the label approves it; a merged PR can't be claimed; no claim goes out when GitHub can't be asked, whileliststill works; waiting requests list last.python -I -B tests/run_all.py test_requests team_chat: both pass.Live: the open request for perf(vk): add floats to storage buffers with the GPU's own atomic, not a compare-and-swap loop #2306 (a contributor's PR) turned into the waiting card when the relay was updated; after adding
testing wantedto perf(vk): add floats to storage buffers with the GPU's own atomic, not a compare-and-swap loop #2306 it opened again on its own within 3 minutes, in both Discord channels, andlistshows it approved.