Skip to content

fix: main's source checks pass again after the batch of merges - #2660

Closed
NotRexed wants to merge 1 commit into
mainfrom
fix/main-tests
Closed

NotRexed wants to merge 1 commit into
mainfrom
fix/main-tests

Conversation

@NotRexed

Copy link
Copy Markdown
Owner

Each of the recently merged PRs was green against its own base, but together on main they broke these source checks (they fail on every open PR):

Check Cause Fix
test_env_on RX_VK_CAPTURE_KEEP_OLD and RX_VK_CAP_BLOCKS were read as set-means-on, so =0 turned them on read through env_on
test_hdr_encode DLSS's TemporalEngine gained two fields after hdr the check matches the fields it means, with anything after them
test_linux_docker_packages the workflow's add-apt-repository -y --no-update ppa:… was read as PPA --no-update options are skipped
test_menu_i18n three English hints changed: the Controls page's ocarina note keys (#1930), mesh shaders' Linux AMD compute path (#2362), the Button prompts' keyboard face (#2435) the 13 translations of each are updated, the new sentences translated

test_display_startup_failure and test_wayland_libdecor_hint already pass on main since #2648. All six pass locally (the Wayland one is skipped on Windows, as its runner says).

🤖 Generated with Claude Code

Each pull request was green on its own base; together on main they failed six checks:
- test_env_on: RX_VK_CAPTURE_KEEP_OLD and RX_VK_CAP_BLOCKS read as set-means-on (=0 turned them on); now env_on.
- test_hdr_encode: DLSS's engine took two more fields after hdr; the check finds the fields it means, whatever follows.
- test_linux_docker_packages: the workflow's add-apt-repository took --no-update, which the check read as the PPA; options
  are skipped now.
- test_menu_i18n: three menu hints changed in English (the Controls page's ocarina note keys, Linux AMD's compute path for
  mesh shaders, the Button prompts' keyboard): their 13 translations follow, each sentence translated.
(test_display_startup_failure and test_wayland_libdecor_hint pass on main since #2648.)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NotRexed

Copy link
Copy Markdown
Owner Author

Superseded: #2651, #2652 and #2654 fixed three of these on main meanwhile; the HDR check's fix is in its own PR.

@NotRexed NotRexed closed this Nov 12, 2026
NotRexed added a commit that referenced this pull request Nov 12, 2026
`test_hdr_encode` still fails on main: DLSS's `TemporalEngine` gained
two fields after `hdr` (#2574), and the check looked for the list ending
there. It now matches the fields it means, whatever follows them. The
rest of #2660 landed separately (#2651, #2652, #2654), so #2660 is
closed in favour of this.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant