Repository navigation
test: the VRAM budget row's fixture builds with clang (llvm-mingw) - #2613
Merged
Merged
Conversation
The fixture takes the menu's budget tables, kVramMinimumOnly with them, but not the row's step that reads it. clang's -Wunused-const-variable (on with -Wall -Werror) then stops the build; GCC does not warn. On Windows with llvm-mingw, the setup CONTRIBUTING.md describes, g++ is clang, so tests/run_all.py fails test_vram_budget_row there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_vram_budget_row.pyfails on Windows with the llvm-mingw setup that CONTRIBUTING.md describes, because thereg++is clang:What changed: the fixture takes the menu's budget tables, and
kVramMinimumOnlycomes with them. The row's step that reads that constant (vk_menu.cpp:1906) does not. The fixture now marks it used with(void)kVramMinimumOnly;. GCC, which CI uses, does not warn, so CI was green while a local Windows run was red.Tested: Windows 11, llvm-mingw 20261104 ucrt-x86_64 (clang 23.1.5):
python -I -B tests/test_vram_budget_row.py --cxx g++failed before the change and passes after it.tests/run_all.py: 438 passed, 3 failed before the change. The other two failures are not this one:test_env_on:HOS_FPS_LOG, already fixed in fix(fps): HOS_FPS_LOG read by the switches' rule, so test_env_on passes on main again #2575;nx2/test_nup_paths: symlinks need Developer Mode on Windows.Not tested: GCC/Linux. The change only adds a reference to a constant, so it does not change what the test checks.
🤖 Generated with Claude Code