Repository navigation
feat(build): record the CPU flags used by the game - #2608
Draft
JooaoPedro15 wants to merge 1 commit into
Draft
JooaoPedro15 wants to merge 1 commit into
JooaoPedro15 wants to merge 1 commit into
Conversation
3 tasks done
Publish normalized build flags beside the game version and embed the same JSON in the startup log. Keep the CPU arguments as a list, distinguish lifted/hot/host base flags, and publish only after successful linking. Updates do not restore these settings yet (issue NotRexed#2577). Refs NotRexed#2576 Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
JooaoPedro15
force-pushed
the
fix/record-build-flags
branch
from
November 12, 2026 16:52
8826458 to
b805e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A built game currently cannot say which CPU target and compilation flags produced it. This makes reports hard to compare and leaves an updater without a record of the original build choices (#2576).
Record the CPU argument list and the normalized base flags for lifted code, hot code and host runtime in
hookshot_build_flags.json. The executable embeds exactly the same JSON and prints it near the start ofhookshot_log.txt; the game folder receives the file besidehookshot_version.txt, including packaged builds with the executable inbin/. Publication uses a temporary file and replacement, after successful linking.The CPU list preserves
-march, optional-mtune, and-ffp-contract=off. The other fields use the existing object-key normalization: include paths omitted, temporary sysroot paths normalized. These are the game's base flags; they do not describe a separately built renderer or optional per-file library defines. Reusing the recorded CPU choices during an update (#2577) is a separate change; this PR does not addRX_CPU_FLAGSor alter the selected CPU flags.Validation:
git diff --checkpasses.CI: all six game-free jobs passed on Windows and Linux, on main
55b976c0plus this change and the pending #2575. That separate validation branch differs from this PR only inhost/oot_high_fps.c, the environment-switch fix from #2575. Both Python shards on both OSes, the SPIR-V fixtures, and workflow lint passed.Current status: #2575 has merged. Rebased onto main
b157c3e8(seven focused local suites pass); the full fork CI is being repeated on this updated branch. The combined CI above records the earlier tested snapshot, not this latest rebase.Overlap: #2673, opened later for the same request, reports a complete Linux game build/run. Only one implementation should land; this remains a draft pending maintainer choice and a real game build/run, which is unavailable on this Mac. This implementation keeps the existing CPU choices, does not introduce
RX_CPU_FLAGS, and publishes the record produced by the child build after successful linking.Fixes #2576
Related: #2577, #2505.
Work is recorded in docs/worklist.md; Discord coordination was unavailable in this environment.
Assisted-by: OpenAI Codex
Co-Authored-By: Codex noreply@openai.com