Repository navigation
fix(fps): respect disabled values for high-FPS diagnostics - #2581
Closed
JooaoPedro15 wants to merge 1 commit into
Closed
JooaoPedro15 wants to merge 1 commit into
JooaoPedro15 wants to merge 1 commit into
Conversation
Use the shared on/off environment parser so HOS_FPS_LOG=0 and other disabled values do not enable periodic diagnostics. This also fixes the existing source regression check. Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed as a duplicate of the earlier #2575, which applies the same environment-parser fix. This branch has passing fork CI, but maintaining two PRs for the same production change would duplicate review work.
Setting
HOS_FPS_LOG=0(orfalse,off,no, or an empty value) currently still enables the periodic high-FPS diagnostics. The presence-only check also fails the existing on/off environment source regression on both Windows and Linux.Use the shared
env_on()parser and documentHOS_FPS_LOG=1in the source comment. Preserve the atomic cache introduced by #2552. Add the reproduced CI failure to the scored worklist.Validation:
tests/test_env_on.py,tests/test_menu_env_on.py, andtests/test_high_fps_fixes.pypass locally.fps_log()function with Clang C11,-Wall -Wextra -Werror: current main passes 9/17 values; this change passes 17/17, checking two cached calls per process.git diff --checkpasses. No game run or GPU performance measurement was possible on this Mac.Related baseline CI: https://github.com/NotRexed/Hookshot/actions/runs/43115711265. Rebased onto main after #2552 and #2562 merged; no dependency PR is included in this diff. Coordination is recorded in the worklist; I could not post in Discord from this environment.
Assisted-by: OpenAI Codex
Co-Authored-By: Codex noreply@openai.com