Repository navigation
test: the updater digest check takes no later-SDK fallback on GitHub's runners - #2543
Merged
Merged
Conversation
…s runners Since NotRexed#2294 the check builds the updater for the SDK's own framework when the .NET 8 reference pack is missing, so it runs on a PC that has only a later SDK. On a GitHub runner that fallback would hide exactly what the builder cares about: a runner image without the .NET 8 pack, or an Updater.cs that no longer builds for net8.0, would pass as net10.0 with one printed line (Joey-Magnus's review of NotRexed#2294). With GITHUB_ACTIONS=true (the test tests/run_all.py already uses to tell a runner from a PC) a failed net8.0 restore now fails the check with dotnet's output. Everywhere else the fallback is unchanged. Assisted-by: Claude Fable 5.2 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is for: on GitHub's runners the updater digest check must keep building for the builder's
net8.0. Since #2294 it falls back to the SDK's own framework when the .NET 8 reference pack is missing. That is right on a PC with only a later SDK and wrong in CI, where it would hide a runner image without the pack, or anUpdater.csthat no longer builds for .NET 8. This is the follow-up @Joey-Magnus suggested in his review of #2294. What is measured: on Linux with only the .NET 10 SDK (10.0.113): run as a PC the check passes through the fallback (20 cases); withGITHUB_ACTIONS=trueit fails with dotnet's NU1100 output; main's file passes in that same situation. Not measured: a runner that really lacks the pack. This pull request's own jobs have .NET 8 installed, so they only show that the normal path is unchanged.Problem
From the review of #2294: "on CI the fallback would hide exactly the regression the builder cares about. If a runner image ever drops the .NET 8 pack, or
Updater.csstarts using an API newer than .NET 8, the check would quietly build for net10.0 and pass, while the real builder no longer compiles. CI only prints one line in that case."What changed
tests/test_updater_asset_digest.py: when thenet8.0restore fails with NU1100 andGITHUB_ACTIONSistrue, the check exits with a message and dotnet's output instead of switching the framework.GITHUB_ACTIONS == "true"is the testtests/run_all.pyalready uses to tell a runner from a PC. Everywhere else the fallback is unchanged.How to try it
How it was tested
Arch Linux, .NET SDK 10.0.113 only (no .NET 8 reference pack), head
2294f29don mainfa2b25b2.GITHUB_ACTIONSunsetUpdater digest cases: 20 passed, 0 failed., exit 0GITHUB_ACTIONS=trueon a GitHub runner the updater must build for the builder's net8.0, and its reference pack is missing: no fallback to a later framework here, then dotnet's NU1100 lines, exit 1GITHUB_ACTIONS=trueNot tested
--stricton a PC is unchanged: the fallback still applies there. The review named--strictas an alternative;run_all.pydoes not pass it on to a check, andGITHUB_ACTIONSis what it already reads.Risks
GITHUB_ACTIONS=truewithout .NET 8 now fails this check instead of passing for a later framework. That is the intent.Overlaps
git merge-tree).Assisted-by: Claude Fable 5.2
Co-Authored-By: Claude Fable 5.2 noreply@anthropic.com