Repository navigation
fix(menu): the Aspect ratio's move for older files skips runs with HOS_ASPECT - #2541
Merged
NotRexed merged 1 commit intoNov 12, 2026
Merged
Conversation
…S_ASPECT menu_init took the shape the host started with as the move of an older file's 16:9. HOS_ASPECT, a debugging switch host/hos_main.c takes instead of the options file, sets that shape too: one run with it (HOS_ASPECT=1.6, say) moved an older ultrawide=0 to the monitor's shape, and the next save kept it. The move now skips runs with HOS_ASPECT set, as hos_main.c does. test_aspect_default.py pins the condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2119's review asked for this, and it came after the merge.
menu_inittakes the shape the host started with as the move of an older options file's 16:9.HOS_ASPECT, a debugging switchhost/hos_main.ctakes instead of the options file, sets that shape too: one run withHOS_ASPECT=1.6and an olderultrawide=0moved the row to Monitor's shape, and the next save kept it, a choice the player never made.What changed
gpu/vk/vk_menu.cppmenu_init: the move skips runs withHOS_ASPECTset, ashos_main.cdoes.tests/test_aspect_default.pypins the condition. Without it the check fails (tried by taking the condition out).Tested
tests/run_all.pyon Windows (llvm-mingw) on main 2dfe901: 421 passed, 33 skipped, 2 failed, both outside this change:test_vram_budget_row(fails the same on main here: clang stops on the unusedkVramMinimumOnly) andtest_portable_builder_startup(itsdotnet publishneeds packages this PC does not have).🤖 Generated with Claude Code