Repository navigation
fix(dlss): #2193's review notes: the tolerance as dlss_checks.h says it, each refused size logged once - #2413
Merged
hckrman101 merged 1 commit intoNov 11, 2026
Conversation
….h says it, each refused size logged once NotRexed#2193 was merged before these three review notes were pushed to it: - prepare's comment says what mode_for takes: at most 1/64 of the range's largest size on each axis (2 pixels at the least), not "a pixel or two". - fail() logs a reason again only when its pointer changes, and the refused message was one buffer, so a second refused size was not logged until the 600th repeat. Two buffers now, the other one for a new size: fail() sees a new pointer and logs each refused size once, as any reason. - test_dlss_checks.py: the assert's message on its own line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2193 was merged before I pushed hckrman101's three review notes to it, so they come here on their own. No behavior changes beyond a log line.
What changed
prepare's comment (gpu/vk/vk_dlss.cpp, near line 300) said a size "a pixel or two" outside a range is taken. It now says whatdlss_checks.h'smode_fortakes: at most 1/64 of the range's largest size on each axis, 2 pixels at the least.fail()invk_temporal.cpplogs a reason again only when its pointer changes, and the refused message was one static buffer, so a second, different refused size was not logged until the 600th repeat. The message now has two buffers, and a new size goes into the other one:fail()sees a new pointer and logs it in its usual format. (Logging it inprepareas well could print a size twice when another reason came between two refusals, becausefail()'s last reason is not reset on success.)test_dlss_checks.py: the assert's message on its own line, like the other asserts (review note).Tested
tests/run_all.pyon Windows (llvm-mingw): 364 passed, 31 skipped, 1 failed:test_recorder_sync(its exit case), which fails the same way on untouched main on this PC.vk_dlss.cpp). Not run in game: the change is a log message and a comment; the refused path itself is fix(dlss): a render size a pixel past a mode's range is that mode's, and a refused size keeps the feature #2193's.🤖 Generated with Claude Code