Repository navigation
feat(builder): the damaged game files a build replaced are listed in the game folder (#2237) - #2254
Merged
Merged
Conversation
…the game folder (NotRexed#2237) The list of damaged dump files and their stand-ins was only printed, once per unpack. It is now also written to hookshot_damaged_files.txt in the game folder, and removed when a later unpack finds no damaged file. The readme's problem table names the file. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2237 (its item 2: write the list into the game folder).
The problem
When a dump is incomplete, the build replaces each damaged game file with a similar one and prints the list (
Your game dump is incomplete: ...). The list is easy to miss in the build's output, and it is printed only once per unpack: a later build or update of the same folder skips the check. The player then reports a missing floor or a wrong texture (#1700), and nothing in the game folder says the dump was the cause.The change
stand_in_damaged_files()also writes the same text tohookshot_damaged_files.txtin the game folder, besidehookshot_version.txt.hookshot_damaged_files.txtin your game folder?".The printed text is unchanged. Items 1, 3 and 4 of #2237 are not in this change.
Tests
nx2/test_nup_zstd_heads.pychecks that the file is written with the damaged file and its stand-in, and that it is removed after an unpack with no damage.Run on Windows 11, Python 3.14:
python -I -B nx2/test_nup_zstd_heads.py: 5 tests, OKpython -I -B nx2/test_nup_stand_in.py: okpython -I -B tests/test_make_game_cache.py: 11 tests, OK (1 skipped)python -I -B tests/test_missing_nup.py: 8 tests, OKNot tested: a full build from a real incomplete dump.
Note: #2096 and #2253 touch the same function; whichever lands second needs a small rebase, which I will do.
🤖 Generated with Claude Code