Repository navigation
fix(build): run offline bake with portable zstd and Clang 18 - #1954
Merged
Merged
Conversation
Arkex-ai
force-pushed
the
fix/bake-portability
branch
from
November 10, 2026 22:04
4e9ac9e to
fd783e5
Compare
Arkex-ai
marked this pull request as ready for review
November 10, 2026 22:26
Arkex-ai
force-pushed
the
fix/bake-portability
branch
2 times, most recently
from
November 11, 2026 00:51
ebfe59a to
e3f9829
Compare
Use the pinned zstandard dependency for dictionary fixtures and decoding while retaining standalone fallbacks. Bound allocation for unknown-size frames and validate complete frames. Probe the actual constexpr assertion failure path so Clang 18 is not rejected for an unrelated unconditional-static function. Refs NotRexed#1931 Assisted-by: GPT-6 (Codex)
Keep the Python decoder as strict as the native reader when a valid compressed frame is followed by corrupt bytes. Cover both declared-size and unknown-size frames. Assisted-by: GPT-6 (Codex)
Arkex-ai
force-pushed
the
fix/bake-portability
branch
from
November 11, 2026 01:19
e3f9829 to
b589084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Offline shader bake tools could fail on a clean Windows setup when they could not find a system Zstd library. They now use the project's existing Python dependency. The compiler check also accepts Clang 18 when it supports the constexpr assertion code the translator uses.
Closes #1931.
Technical changes
Validation
b5890847ond47206ed, all 5 portability checks passed on Windows LLVM and Ubuntu Clang 18. The checks cover real dictionary frames, corrupt and truncated input, native-reader fallback and the compiler probe.