Repository navigation
fix(vk): reject unbound imported buffers and roll back ownership - #1718
Conversation
d45f24b to
ca857d8
Compare
|
Rebased onto main Head
Full-suite/current API13 native validation remains separate and pending. |
|
Thanks, agreed. I rewrote this and the other four active PR descriptions: the plain-language problem comes first, followed by brief technical changes and one validation section with measured test results and current-head CI links. Rebase history and repeated status lists are removed; earlier native evidence is folded separately so it is not confused with the current head. No code changed. |
Check both host-pointer and DMA-buf binding results before publication. Preserve fallback and hold retry semantics while releasing only successfully owned resources at existing cleanup points. Assisted-by: GPT-6 (OpenAI)
Assisted-by: GPT-6 (Codex)
ca857d8 to
27d7e7c
Compare
|
Rebased onto main All 34 cases pass on Windows/Linux, including sanitizers; 11 mutations are rejected. Full local suite: 298 passed / 2 failed / 21 skipped, versus 297 / 2 / 21 on the exact baseline, with the same two local failures. Fresh exact-head CIs are linked in the description; current-head native gameplay remains untested. |
Summary
A failed
vkBindBufferMemorycould still be reported as a usable imported buffer. Both host-pointer and non-sparse DMA-buf factories now reject failed binding and roll back the resources they own before publishing an address.Technical changes
destroy_import_bufferhelper so associated texel views are released before raw buffer destruction.Validation
Head
27d7e7c, based on main117eae7:Earlier native evidence and limits
At
2ec6ae3(API12), serial and parallel/batch checkpoint runs passed with fixed 2x interpolation, resize and six decoded 3440x1440 captures. Both exited normally and preserved the original checkpoint. This covers the healthy Windows host-pointer path; native DMA-buf failure, GPU OOM and campaign coverage are untested.