Remove redundant stdlib declarations and module gitignores - #346
Merged
Merged
Conversation
The Kotlin Gradle plugin adds kotlin-stdlib to every Kotlin module, so drop the 28 explicit kotlin-stdlib-jdk8 declarations and their catalog entry. kotlin-stdlib-jdk7/jdk8 now resolve to 1.8.21, requested by okhttp 4.12.0, instead of being lifted to 2.2.21. Since Kotlin 1.8 both are empty artifacts, and kotlin-stdlib only requires them to be at least 1.8.0. The root .gitignore already ignores build/, so delete the 35 module .gitignore files that only ignored /build, and move app's /release rule to the root as /app/release/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This was referenced Oct 4, 2026
fornewid
added a commit
that referenced
this pull request
Oct 4, 2026
Removing the explicit kotlin-stdlib-jdk8 declarations in #346 let okhttp 4.12.0 pull kotlin-stdlib-jdk7/jdk8 down to 1.8.21. Add kotlin-bom, at the Kotlin plugin's version, as a platform in configureKotlin(), so the Android modules resolve Kotlin artifacts at 2.2.21 again. Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fornewid
added a commit
that referenced
this pull request
Oct 4, 2026
#346 moved app's /release rule to the root .gitignore as /app/release/ and deleted app/.gitignore. That went beyond removing the module .gitignore files that only contained /build, so restore app/.gitignore with /release and drop the root rule. Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes declarations that other mechanisms already cover.
kotlin-stdlibto every Kotlin module (kotlin.stdlib.default.dependencyisn't disabled), so the 28 explicitimplementation libs.kotlin.stdliblines and thekotlin-stdlibcatalog entry go. Twodependenciesblocks that only held that line are removed..gitignorealready ignoresbuild/, so the 35 module.gitignorefiles that only contained/buildare deleted.app/.gitignore's/releasemoves to the root as/app/release/; it's anchored so that the trackedapp/src/release/stays tracked.dependencyGuard baseline
kotlin-stdlib-jdk7andkotlin-stdlib-jdk8now resolve to 1.8.21 instead of 2.2.21. The explicitkotlin-stdlib-jdk8:2.2.21declaration used to lift them; now they come from okhttp 4.12.0. This is expected and harmless:MANIFEST.MFandMETA-INF/versions/9/module-info.class.:app:checkDebugDuplicateClassesand:app:checkReleaseDuplicateClassespass.Verification
./gradlew dependencyGuard manifestShield proguardShieldFast moduleRulespasses. The proguardShield, manifestShield and module-rules baselines are unchanged.git check-ignorestill ignores every module'sbuild/andapp/release/outputs, andgit statusshows no new untracked files.π€ Generated with Claude Code
https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ