Skip to content

ci: give xvfb-run a minute to end after the smoke test's --quit #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KnifeLemon merged 1 commit into from
Nov 4, 2026
Merged

ci: give xvfb-run a minute to end after the smoke test's --quit #1146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion build/smoke-launch-app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ def check_input_hook():
time.sleep(0.05)
if quitter.returncode != 0:
raise RuntimeError(f'filee --quit exited with {quitter.returncode}.')
if process.wait(timeout=15) != 0:
# --quit came back, so Filee has ended. On Linux this waits for xvfb-run to take Xvfb down too, which now and
# then takes longer than 15 s on the arm64 runners.
if process.wait(timeout=60) != 0:
raise RuntimeError('The desktop app did not exit cleanly.')
if is_linux:
check_input_hook()
Expand Down
Loading