Repository navigation
ci: give xvfb-run a minute to end after the smoke test's --quit - #1146
Merged
Merged
Conversation
The linux-arm64 package job failed on several PRs in one day at this wait, after --quit had already succeeded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
portable / Package on Ubuntu 22.04 (linux-arm64)failed on #1124 and #1131 atprocess.wait(timeout=15)inbuild/smoke-launch-app.py, and passed when run again.At that line
filee --quithas already come back with 0, and it only does that once Filee has ended (it has its own 30 s limit). What the script is still waiting for on Linux isxvfb-run, which takes Xvfb down after Filee ends. So a slow runner failed the job although Filee quit properly. This is my reading of the script and the logs: the job doesn't log whatxvfb-runwas doing.The wait is now 60 s. A Filee that doesn't quit is still caught by the
--quitlimit.🤖 Generated with Claude Code