Repository navigation
fix: Fake Role API + make duplicate commands easier to fix - #866
Merged
Merged
Conversation
louis1706
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
some fixes for fake role API, also log duplicate commands so it's easier to see what plugin caused them
What is the current behavior? (You can also link to an open issue here)
Fake role API broken, I had to make change to see what plugin had duplicate command.
What is the new behavior? (if this is a feature change)
Fake role API fixed, it's easy to see what plugin had duplicate command
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
RoleData constructor is changed in order to fix bug. This is necessary cuz I'm a dum dum (I don't think anyones really used the Fake role API yet though)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other