Skip to content

fix: Fake Role API + make duplicate commands easier to fix - #866

Merged
Someone-193 merged 1 commit into
ExMod-Team:masterfrom
Someone-193:tweaks
Oct 15, 2026
Merged

Someone-193 merged 1 commit into
ExMod-Team:masterfrom
Someone-193:tweaks

Conversation

@Someone-193

Copy link
Copy Markdown
Collaborator

Description

Describe the changes
some fixes for fake role API, also log duplicate commands so it's easier to see what plugin caused them

What is the current behavior? (You can also link to an open issue here)
Fake role API broken, I had to make change to see what plugin had duplicate command.

What is the new behavior? (if this is a feature change)
Fake role API fixed, it's easy to see what plugin had duplicate command

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
RoleData constructor is changed in order to fix bug. This is necessary cuz I'm a dum dum (I don't think anyones really used the Fake role API yet though)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Someone-193
Someone-193 merged commit 1a64e79 into ExMod-Team:master Oct 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants