fix: Stop dispatching messages after close - #362
Open
brennanbutler01 wants to merge 1 commit into
Open
brennanbutler01 wants to merge 1 commit into
brennanbutler01 wants to merge 1 commit into
Conversation
Check connection state before dispatching each parsed event so closing from a listener suppresses the remaining messages in the same chunk. Add real-server regressions for ordinary and named events, open-connection controls, and a patch changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When several events arrive in one response chunk, calling
close()from the first listener still delivers the remaining events withreadyState === CLOSED. Reproduced on 4.1.0 (the 4.x release used by the downstream application), published 5.1.1, and currentmain.The event dispatch steps require dispatch to stop when the connection is closed. Check the state at the parser's event callback so a listener can close the connection before another buffered event is delivered. No public API changes.
Verification
git diff --checkpass.Verified on macOS with Node 24.13.0, Vitest 4.1.10, and Playwright 1.61.1. Firefox, iOS Safari, Deno, and happy-dom were not run. Local verification reused an isolated toolchain; dependency manifests and lockfiles are unchanged. Includes a patch changeset.
Prepared with OpenAI Codex assistance, including the reproduction, implementation, tests, and local review.