fix: stop dispatching SSE events after close - #364
Open
zubairchowdhury888-art wants to merge 1 commit into
Open
zubairchowdhury888-art wants to merge 1 commit into
zubairchowdhury888-art wants to merge 1 commit into
Conversation
Once the EventSource has been closed - including by a listener during a previous event's dispatch, when several parsed events arrive in one chunk - the event dispatch steps stop and no further buffered events are dispatched, per the EventSource specification. Fixes EventSource#362 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When multiple SSE events arrive in a single buffered chunk, calling
EventSource.close()from the first event listener previously allowedsubsequent buffered events to continue dispatching.
This change adds a closed-state guard to stop event dispatch once the
EventSourcehas reachedCLOSED.Fixes #362
Regression test
Added a regression test where:
first,second, andthirdevents arrive in a single chunkEventSourceis closed from the first event listenerThe unmodified upstream implementation reproduced the issue:
messages dispatched: expected 3 to be 1The same test passes after the fix.
Verification
Changes
src/EventSource.ts— closed-state guardtest/client.test.ts— regression test.changeset/stop-dispatch-after-close.md— patch changesetNo public API change and no unrelated refactoring.
The implementation is intentionally minimal: it prevents further event dispatch when the
EventSourceis alreadyCLOSED.