Repository navigation
Regulated Pure Pursuit: approach the goal inside its tolerance - #118
Merged
Merged
Conversation
Near the goal the controller stopped translating at the system's goal tolerance, the same threshold the system uses for success, and with localization noise it switched between turning to the goal heading and tracking the path, spinning in place. It now uses the strictest of its own and the system's tolerances, drives to half of it before turning to the goal heading, and keeps turning until the robot leaves the whole tolerance (reset on a new goal). Fixes #115 Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
Near the goal, the controller stopped translating at the system's goal tolerance, the same threshold the system uses for success. With localization noise it switched between turning to the goal heading and tracking the path, spinning left and right in place with zero linear speed.
Now:
xy_goal_tolerance/yaw_goal_toleranceand the system'sgoal_tolerance.*, so its own parameters take effect again.Validation
Summit warehouse, recorded
cmd_vel:Battery of the playgrounds that use RPP (before → after):
In the Summit cases the remaining error is localization: the robot ends 0.17–0.32 m from the goal by its own estimate.
Tests
8 new tests (
regulated_pp_goal_approach_tests):4 of them fail on the previous code.