Repository navigation
Conversation
Carry nullable telemetry identity separately from the normalized assignment context through online and offline providers and both native bridges. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
This was referenced Oct 23, 2026
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 1116fda | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves the difference between an omitted targeting key and an explicit empty string when React Native forwards evaluations to native telemetry. Implements the nullable-identity prerequisite for FFL-3436.
Online and offline providers capture key presence before assignment-context normalization. New additive Android/iOS bridge methods carry that nullable identity separately: missing or malformed Unicode is omitted; an explicit empty string remains empty; valid strings are preserved for native consent enforcement. Assignment inputs, exposure attribution and subject opt-out continue to use the original evaluation context. A failed online refresh retains the previous snapshot's identity.
Motivation
Normalizing a missing key to an empty string loses information needed by the client telemetry privacy contract. Keeping a separate optional telemetry value preserves that information without changing targeting or bucketing.
Additional Notes
Draft — merge/release blockers:
__ddSetEvaluationContext. The current^3.1.0range permits incompatible older core packages; a supporting version has not been assigned yet.This PR is the nullable-targeting-key foundation. Configuration-level consent transport and error/default evaluation replay remain follow-up work in FFL-3436. It does not complete React Native privacy enforcement.
Validation:
Review checklist (to be filled by reviewers)