Repository navigation
Conversation
2 of 9 tasks
Co-authored-by: Vickie Boettcher <vickie.fridge@datadoghq.com>
Co-authored-by: Vickie Boettcher <vickie.fridge@datadoghq.com>
…tions Co-authored-by: Vickie Boettcher <vickie.fridge@datadoghq.com>
Co-authored-by: Vickie Boettcher <vickie.fridge@datadoghq.com>
Keep consent in the repository evaluation snapshot alongside the updated context and opt-out policy. Cover their interaction in native evaluations and consent-aware bridge replay. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Keep the full iOS suite and paired artifact validation, and distinguish historical results from pending merged-head Apple CI. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Add a nullable telemetry-only targeting key while retaining the original context for exposures and subject opt-out. Cover omission, empty strings, Unicode, consent modes, and replay counts. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
Draft
7 tasks
Opt the fallback test file into Internal SPI so the nullable telemetry replay test compiles on all Apple platforms. Environment: Datadog workspace Co-Authored-By: Codex GPT-6 <noreply@localhost>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Protect flag evaluation telemetry unless the evaluated configuration explicitly enables
observeFullEvaluationData. Implements FFL-3432, following the updated FFL-3427 / FFL-3437 client scope. Existing Swift value representations provide context ownership; no new bounded-context architecture is introduced. Paired provider: #45.How?
sendFlagEvaluation(key:assignment:context:telemetryTargetingKey:observeFullEvaluationData:flagError:). Aniltelemetry key omitstargeting_keywithout dropping the evaluation; an explicit empty string remains empty. The original context still supplies full-mode attributes and preserves the assignment/exposure subject and subject-level telemetry opt-out. Existing replay overloads retain their behavior. Consumer wiring: React Native #1510.Validation
The detailed artifact evidence below is historical and predates the develop merge and nullable replay change. On current head
a0effb2d77e94890f1ca6ea5863daebdfdc3f0f4, lint, API-surface verification, SPI documentation and paired artifact validation are green; Apple platform unit suites remain pending. New native tests cover nullable replay, encoded omission versus empty, Unicode keys, preserved counts/attributes/exposures, and subject opt-out; they were added to source but were not compiled or executed in the Linux workspace.macOS/Xcode 26 artifact job 2167527865 passed against native
ed1ca0de3fecf4b07e118f97fc3929092f09d026and providera90606193c1fc27fdab43cdd5f466575cf2f7b01:Source identities, binary SHA-256, lockfiles, build logs and wire bodies are job artifacts. Native lint, API-surface verification and SPI documentation builds passed. The Linux workspace itself has no Apple toolchain; Python verifier/compatibility tests and grammar checks run locally. Details and React Native interface handoff:
docs/FLAGS_PII_VALIDATION.md.Review checklist
Draft remains gated on broader CI and owner/release review. The provider's existing Xcode 16.2 CI cannot build the paired Swift 6.2 package and needs a compatible runner. The app probes use a controlled loopback HTTP service. Physical-device/live-backend dogfooding and React Native malformed-input behavior are not covered.