Repository navigation
chore(dev): shared compile cache and worktree helper - #1477
duncanista wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83bd013cec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
duncanista
changed the title
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1447a0e5ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 111f247bc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…x printed commands
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7f16a1faf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -n "${SCCACHE_BIN:-}" ] && [ -x "$SCCACHE_BIN" ]; then echo "$SCCACHE_BIN"; return 0; fi | ||
| if [ -x "$TOOLS_DIR/bin/sccache" ]; then echo "$TOOLS_DIR/bin/sccache"; return 0; fi | ||
| if command -v sccache >/dev/null 2>&1; then command -v sccache; return 0; fi |
There was a problem hiding this comment.
When SCCACHE_BIN names a relative executable, or sccache is found through a relative PATH entry, find_sccache returns that relative path unchanged. In the documented eval "$(scripts/dev/setup-build-cache.sh)" && cd bottlecap && cargo build flow, the exported RUSTC_WRAPPER is then resolved from bottlecap/ rather than the directory where it was found, so Cargo cannot launch the wrapper; canonicalize the discovered executable before printing the export.
AGENTS.md reference: AGENTS.md:L17-L17
Useful? React with 👍 / 👎.
TL;DR: A script that sets up sccache and one shared build directory, plus a helper for git worktrees.
Why: A cold bottlecap build takes minutes, and with one worktree per change each one rebuilt everything. This shares the dependency builds across worktrees, while each worktree still builds its own bottlecap code.
Overview
Jira: SVLS-9976
Stacked on #1476 (
jordan.gonzalez/release-symbols/feature).Opt-in helpers to build and test bottlecap fast in many worktrees. Nothing edits shell rc
files,
~/.cargo/config.tomlor Docker settings.scripts/dev/setup-build-cache.sh: finds or installs a pinnedsccache(v0.19.0, sha256checked) and prints the env for one shared
CARGO_TARGET_DIR.--testsgives aper-worktree target dir for tests that spawn the
bottlecapbinary.scripts/dev/worktree.sh: creates a git worktree that uses the shared cache.scripts/dev/README.md: usage, the reason for one shared target dir, lock contention, andhow to get the release binaries from the symbols job.
AGENTS.md: a short "Build and test fast" section..gitignore:.worktrees.Size: 291 core lines, 456 lines in total.
Testing