Repository navigation
chore(dev): patch-deps.sh to build against local dependency checkouts - #1478
duncanista wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab01123569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 229b80652b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
TL;DR: A script that points bottlecap at a local checkout of serverless-components or libdatadog, and restores
Cargo.tomlandCargo.lockafterwards.Why: Testing a dependency fix today means editing
Cargo.tomlby hand and remembering to undo it. This makes it one command, and it refuses to restore over edits it did not make.Overview
Jira: SVLS-9976
Stacked on #1477 (
jordan.gonzalez/dev-build-cache/feature).scripts/dev/patch-deps.shpoints bottlecap at local checkouts of serverless-components,libdatadog, saluki, dd-trace-rs or libddwaf-rust with
[patch]entries in a marked block,and removes them again.
add,remove,status,restore. The firstaddbacks upCargo.lockinbottlecap/.patch-deps/(ignored) with its sha256.statusshowsNOT USEDfor a patch that cargo does not use (version not semvercompatible with the lock); exit code 3.
restoreandremoverefuse to run (exit 4) when the lock changed after the backup, unless--force.Size: 249 core lines, 282 lines in total.
Testing
addthenrestoregives a byte-identicalCargo.tomlandCargo.lock.