Repository navigation
ci: add a cargo-machete gate for unused dependencies - #1471
Open
duncanista wants to merge 1 commit into
Open
duncanista wants to merge 1 commit into
duncanista wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: b1575de | Docs | View more details | Give us feedback! |
duncanista
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Adds a CI job (cargo-machete) that fails when
Cargo.tomllists a dependency that the code does not use.Why: The 6 unused dependencies that #1470 removes built up over time, because nothing caught them.
Overview
Jira: SVLS-9975
Stacked on #1470 (
jordan.gonzalez/remove-unused-deps/feature).Add the
Unused Dependenciesjob:cargo-machete0.9.2 throughtaiki-e/install-actionv2.87.28. It is static analysis, with no build, so it is fast and deterministic. A crate used
only through a string path or kept as a version bound goes in
[package.metadata.cargo-machete] ignored(previous PR). It is not a required check.Size: 17 core lines, 17 lines in total.
Testing
cargo machete: pass