Repository navigation
chore(deps): remove 6 unused dependencies - #1470
duncanista wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
duncanista
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues with the unused-dependency cleanup.
No open issues 🎉
What changed in this PR
Removes six unused direct dependencies from the Rust Lambda extension and prepares dependency metadata for the cargo-machete CI check planned in #1471.
Changes:
- Removes five regular dependencies and the
proptestdev-dependency. - Adds cargo-machete exclusions with comments explaining intentionally retained dependencies.
- Updates the lockfile and removes four third-party license entries.
| File | Description |
|---|---|
| bottlecap/LICENSE-3rdparty.csv | Removes license entries for bit-set, bit-vec, rusty-fork, and wait-timeout. |
| bottlecap/Cargo.toml | Removes six unused dependencies and documents cargo-machete exclusions. |
| bottlecap/Cargo.lock | Updates dependency references and removes unused package versions and dependency edges. |
Review effort: Balanced
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f36a2d7e5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| checksum = "08807e080ed7f9d5433fa9b275196cfc35414f66a0c79d864dc51a0d825231a3" | ||
| dependencies = [ | ||
| "bit-vec 0.8.0", | ||
| "bit-vec", |
There was a problem hiding this comment.
The PR summary says the lockfile drops bit-set and bit-vec, but this hunk only removes versions 0.8.0; versions 0.5.3 and 0.6.3 remain at bottlecap/Cargo.lock:417-430 through httpmock -> basic-cookies -> lalrpop. Update the summary to distinguish removing these crates from the production dependency graph from their continued presence in the dev-dependency lock graph.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
TL;DR: Removes 6 dependencies that no code uses: indexmap, serde-aux, lazy_static, log, ddsketch-agent and proptest.
Why: Less to compile, audit and keep up to date. The next PR (#1471) adds a CI check so that unused dependencies do not come back.
Overview
Jira: SVLS-9975
Stacked on #1469 (
jordan.gonzalez/cargo-deny/feature).indexmap,serde-aux,lazy_static,log,ddsketch-agentand the dev-dependencyproptest. The lock dropsbit-set,bit-vec,rusty-forkandwait-timeout, andLICENSE-3rdparty.csvdrops the same 4 rows, so therequired "Valid LICENSE-3rdparty.csv" check passes.
[package.metadata.cargo-machete] ignoredlists the 4 crates that stay on purpose, with thereason in a comment: version bounds on transitive crates,
aws-lc-rsreached throughrustls::crypto, andserde_bytesused in a#[serde(with)]string. The next PR adds thegate that reads it.
Size: 15 core lines, 69 lines in total.
Testing
cargo metadata --locked: passcargo deny --locked check: passcargo machete: passdd-rust-license-tool check: passcargo clippy --workspace --all-targets --features default -- -D warnings: passcargo clippy --workspace --all-targets --features default,test-mode -- -D warnings: passcompile_bottlecap.sh, arm64, FIPS=1).