Repository navigation
[APPS-2961] Update: warn that Vite below 6.4 is deprecated and run the repo on Node 24 - #627
Conversation
|
@codex review |
Live Debugger Runtime BenchmarkSDK-loaded dormant-probe runtime overhead, measured against an uninstrumented bundle in the same browser session.
What do the Tiny and Hot workloads represent? Browser Debugger SDK: Full diagnosticsRaw samples are in the |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Four remaining style findings require named locals for nested calls and regular-expression setup in warning logging and test assertions to follow repository conventions.
4 open issues
What changed in this PR
Adds advisory Vite version warnings through the shared plugin factory while preserving the existing peer dependency range. It also moves the repository’s Node.js pin to 24.14.1.
Changes:
- Warns for Vite below 6.4 or above the tested 8.x range without blocking builds.
- Adds version-check and factory tests covering warning text, other bundlers, and disabled logging.
- Updates the Volta Node.js pin from 20.19.4 to 24.14.1.
| File | Description |
|---|---|
packages/factory/src/index.ts |
Emits the Vite version warning during initialization. |
packages/factory/src/index.test.ts |
Tests warning behavior and logging suppression. |
packages/factory/src/helpers/vite-version.ts |
Defines version bounds, checks, and warning messages. |
packages/factory/src/helpers/vite-version.test.ts |
Tests version handling, message wording, and peer-range alignment. |
package.json |
Pins repository development to Node.js 24.14.1. |
Review effort: Balanced
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c1fd785 to
2263c27
Compare
2263c27 to
281bc20
Compare
Volta's pin sets the Node version for local development and for every CI job (setup-node reads it). Node 20 reached end of life on 2026-04-30; the publish job already uses Node 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every plugin now warns at startup on an older Vite, and on a Vite above 8.x, while the peer range stays `>= 5.x <= 8.x` so no install breaks. A test ties the upper bound to the peer range in package.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
281bc20 to
f55653d
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|

Motivation
@datadog/vite-pluginstill declaresvite >= 5.x <= 8.x.Changes
8 changes across vite-version.ts, index.ts, vite-version.test.ts, index.test.ts, package.json, publish.yaml and nockInterceptors.test.ts
semverand returns the warning for one outside it, or nothing for an unreadable one.vite-version.tsvite-version.tsindex.tslogLevel: 'none', and ties the upper bound to the declared peer range.vite-version.test.ts,index.test.tssemver7.7.2, already in the lockfile, as a dependency of@dd/factoryand so of each published plugin.package.jsonpackage.json"24", as the other workflows do.publish.yamlnockInterceptors.test.tsQA Instructions
f55653d9. Setup: build-plugins: Testing and QA Guide.vite buildon Vite 5.4.21 and 6.3.5Vite 5.4.21 is deprecated in Datadog's Vite plugin: please upgrade to Vite 6.4 or later.vite buildon Vite 6.4.5 and 8.3.4✓ built in 30msand19msTMPDIR=/private/tmp yarn test:unitbelowrun.shand its outputBlast Radius
warnings.count.Out of Scope / Follow-ups
3 items deferred
>=6.4.0 <9Documentation
🤖 Generated with Claude Code