gui/quickfort: change transform hotkeys to ,.[] - #1627
Open
Alistair-Afton wants to merge 1 commit into
Open
Alistair-Afton wants to merge 1 commit into
Alistair-Afton wants to merge 1 commit into
Conversation
In the game font, () is easily mistaken for <>, which made the displayed rotate keys look wrong. Use ,. for rotate and [] for flips, which are unambiguous. Update the stale transform_widgets test keys to match. Fixes DFHack/dfhack#5710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DFHack/dfhack#5710
In the DF font,
(and)are nearly indistinguishable from<and>, so the transform hotkey labels ingui/quickfortlooked wrong even though they were accurate. The rotate keys are now,/.(the unshifted<>keys) and the flip keys are[/]— all unambiguous in the font.Also updated the
transform_widgetstest intest/gui/quickfort.lua, which referenced staleA_MOVE_*keys that no longer drive these widgets, to use the actual current bindings.Test plan
t, pressed,/./[/]— the transform list accumulatedccw,cw,flipv,fliph(with correct reduction:ccw+cw-> identity,flipv+fliph+ccw->cw), and the panel labels now render,.[]instead of()_=()_=no longer trigger transforms