ci: raise lua test retry timeout to 3 minutes - #5943
Merged
Merged
Conversation
The retry wrapper deletes test_status.json on each attempt, so every attempt must run the entire suite (DF boot + all tests + shutdown) within the timeout. The suite has grown enough that a full Windows run now exceeds 60s, making every attempt time out deterministically.
2 tasks
SilasD
approved these changes
Sep 17, 2026
SilasD
left a comment
Contributor
There was a problem hiding this comment.
this is a necessary fix now that we're actually getting some test suite coverage.
the change is minimal and looks both reasonable and correct.
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run lua testsstep retries vianick-fields/retrywithtimeout_minutes: 1.ci/run-tests.pydeletestest_status.jsonon startup, so--resumeonly helps DF restarts within an attempt, not across outer retries.Test plan