Skip to content

ci: raise lua test retry timeout to 3 minutes - #5943

Merged
ab9rf merged 1 commit into
DFHack:developfrom
Alistair-Afton:ci-test-timeout
Sep 17, 2026
Merged

ab9rf merged 1 commit into
DFHack:developfrom
Alistair-Afton:ci-test-timeout

Conversation

@Alistair-Afton

Copy link
Copy Markdown
Contributor

Summary

  • The Run lua tests step retries via nick-fields/retry with timeout_minutes: 1.
  • Each attempt reruns the entire suite: ci/run-tests.py deletes test_status.json on startup, so --resume only helps DF restarts within an attempt, not across outer retries.
  • The suite has grown enough that a full Windows run (DF boot + all tests + quit) now exceeds 60s. PR test: add in-game regression tests for five more plugins #5936 hit this: all 324 tests passed, but every attempt died at the 60s mark during shutdown, failing the job.
  • Raises the per-attempt limit to 3 minutes. Worst-case wall time for a genuinely hung suite goes from 3 to 9 minutes, which is still bounded.

Test plan

The retry wrapper deletes test_status.json on each attempt, so every
attempt must run the entire suite (DF boot + all tests + shutdown)
within the timeout. The suite has grown enough that a full Windows run
now exceeds 60s, making every attempt time out deterministically.

@SilasD SilasD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a necessary fix now that we're actually getting some test suite coverage.

the change is minimal and looks both reasonable and correct.

@ab9rf
ab9rf merged commit 0d64d13 into DFHack:develop Sep 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants