Skip to content

test: add in-game regression tests for five more plugins - #5936

Open
Alistair-Afton wants to merge 1 commit into
DFHack:developfrom
Alistair-Afton:test-plugin-coverage-9
Open

Alistair-Afton wants to merge 1 commit into
DFHack:developfrom
Alistair-Afton:test-plugin-coverage-9

Conversation

@Alistair-Afton

Copy link
Copy Markdown
Contributor

Summary

  • reveal: reveal/unreveal/revtoggle hidden-flag round-trips, already-revealed and disabled-demon guards
  • dwarfvet: status output reflects enable state, now checkup, usage errors
  • cleaners: clean map|units|items|plants|all run clean, usage errors
  • cleanconst: full item scan for bogus construction flags
  • cleanowned: dryrun scans with all filters, usage errors

Test plan

  • All 20 new tests pass in-game (42/42 checks)
  • ci/lint.py clean

@Alistair-Afton

Copy link
Copy Markdown
Contributor Author

The Windows test failure is an infra margin issue, not a test failure: the artifact shows all 324 tests passed and the suite reached the quit command, but the nick-fields/retry wrapper killed DF at the 60s mark. Each attempt reruns the whole suite (run-tests.py deletes test_status.json on startup), so any run over 60s fails deterministically. Opened #5943 to raise the timeout to 3 minutes.

Covers reveal, dwarfvet, cleaners, cleanconst, and cleanowned:
map reveal/unreveal/revtoggle hidden-flag round-trips, dwarfvet
status/checkup, clean subcommand coverage and usage errors, and
cleanowned dry-run scans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant