Repository navigation
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit da3bbd6. Configure here.
🦋 Changeset detectedLatest commit: 15ed64c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
| expect(trigger).toHaveClass(styles.collapsible__trigger); | ||
| }); | ||
|
|
||
| it('keeps the focus-visible outline inside clipping wrappers', () => { |
There was a problem hiding this comment.
please drop this test,
it breaks under harmless change and misses the real problem
There was a problem hiding this comment.
what would be better instead is a focus case in
sidebar-collapsible-item.spec.ts
i.e. click body, Tab, toBeFocused, screenshot, in light and dark similar to checkbox.spec.ts
A new snapshot will be generated (run VRT)
Signed-off-by: jay23606 <4602056+jay23606@users.noreply.github.com>

Bug
SidebarCollapsibleItem(andCollapsible.Trigger) gives no visible focus ring on keyboard focus. The trigger is anEmptyButton, which setsoutline: noneand has no:focus-visiblestyle. The chevron is also hidden until hover, so keyboard users get no cue that focus is on the expand control.Change
Collapsible.module.css: add a:focus-visibleoutline on.collapsible__trigger, and reveal the chevron while the trigger is focused.Collapsible.test.tsx: add a render check that the trigger carries the module class the focus rule targets, and a check that the stylesheet declares the focus-visible outline.Testing
yarn vitest run src/components/Collapsible/Collapsible.test.tsx -t "shows a focus-visible outline": passes on this branch; fails on the base CSS with the expected assertion.yarn vitest run src/components/Collapsible: 4/4 pass.yarn typecheckandyarn eslint src/components/Collapsible/Collapsible.test.tsx: pass.Not tested
:focus-visible, so the outline is verified by reading the stylesheet, not by computed style.Regression test: fails on base twice (//.{0,2}collapsible__trigger:focus-visible/), passes on fix twice (
yarn vitest run src/components/Collapsible/Collapsible.test.tsx -t "shows a focus-visible outline")Fixes #1306
Note
Low Risk
CSS-only accessibility styling and tests; no logic or data-path changes.
Overview
Fixes missing keyboard focus feedback on
Collapsible.Trigger(includingSidebarCollapsibleItem) by styling:focus-visibleon.collapsible__trigger: a 2px outline using--click-global-color-outline-default, with insetoutline-offsetso the ring stays visible inside overflow-clipping sidebars.While the trigger has keyboard focus, the expand chevron is now shown (same as on header hover), since it was otherwise hidden until hover.
Adds regression tests that the trigger gets
collapsible__triggerand that the module CSS declares the focus ring rule; ships as a patch changeset for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit 45e21ed. Bugbot is set up for automated code reviews on this repo. Configure here.