Skip to content

fix(EmptyButton): add focus-visible ring and show Collapsible chevron on focus - #1320

Closed
kanakkholwal wants to merge 3 commits into
ClickHouse:mainfrom
kanakkholwal:fix/empty-button-focus-ring
Closed

kanakkholwal wants to merge 3 commits into
ClickHouse:mainfrom
kanakkholwal:fix/empty-button-focus-ring

Conversation

@kanakkholwal

@kanakkholwal kanakkholwal commented Nov 19, 2026 •

Copy link
Copy Markdown

Description

  • EmptyButton gets a :focus-visible ring (global outline token), also reaches CrossButton
  • Collapsible chevron shows on :focus-within, not only on hover

Links and tickets

Fixes #1306

Good to know

Chevron stays hover-only for mouse users, so the design is unchanged. No Docker locally, so visual snapshots are left to CI.

Checklist

  • Breaking changes? (add migration notes in changesets)
  • Visual changes? (specify in changesets)
  • Design review needed?

Note

Low Risk
CSS-only visual and focus affordances; no logic, API, or data-handling changes.

Overview
Improves keyboard accessibility without changing mouse hover behavior.

EmptyButton now shows a focus-visible outline using --click-global-color-outline-default, implemented with :where() so existing styled overrides (e.g. CrossButton, popover close buttons) keep winning on specificity. Collapsible reveals the trigger chevron when .collapsible__trigger has :focus-visible, in addition to the existing header hover rule.

Reviewed by Cursor Bugbot for commit e47bcd3. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e47bcd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clickhouse/click-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 5cc9ead. Configure here.

@XOP XOP added bug Something isn't working duplicate This issue or pull request already exists labels Nov 19, 2026
@XOP

XOP commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

@kanakkholwal thank you for contribution,
please note that duplicate PR exists: #1312

@XOP XOP added the a11y Accessibility improvements label Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Accessibility improvements bug Something isn't working duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SidebarCollapsibleItem shows no keyboard focus and hides its expand chevron until hover

2 participants