Repository navigation
fix(EmptyButton): add focus-visible ring and show Collapsible chevron on focus - #1320
Closed
kanakkholwal wants to merge 3 commits into
Closed
kanakkholwal wants to merge 3 commits into
kanakkholwal wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: e47bcd3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 5cc9ead. Configure here.
Contributor
|
@kanakkholwal thank you for contribution, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
EmptyButtongets a:focus-visiblering (global outline token), also reachesCrossButtonCollapsiblechevron shows on:focus-within, not only on hoverLinks and tickets
Fixes #1306
Good to know
Chevron stays hover-only for mouse users, so the design is unchanged. No Docker locally, so visual snapshots are left to CI.
Checklist
Note
Low Risk
CSS-only visual and focus affordances; no logic, API, or data-handling changes.
Overview
Improves keyboard accessibility without changing mouse hover behavior.
EmptyButtonnow shows a focus-visible outline using--click-global-color-outline-default, implemented with:where()so existing styled overrides (e.g.CrossButton, popover close buttons) keep winning on specificity.Collapsiblereveals the trigger chevron when.collapsible__triggerhas:focus-visible, in addition to the existing header hover rule.Reviewed by Cursor Bugbot for commit e47bcd3. Bugbot is set up for automated code reviews on this repo. Configure here.