wallet: Distinguish unavailable Bails checks by BenWestgate · Pull Request #80 · BenWestgate/python-codex32

BenWestgate · 2026-09-30T17:30:48Z

Why

On a Python/OpenSSL build without RIPEMD-160, a valid standard Bails identifier is not checked, but the no-record restore prompt previously said the cards were wrong or mixed up. The frozen d9k8 vector reproduces this when hashlib.new("ripemd160", ...) raises ValueError.

Change

Report the standard Bails check as unavailable/inconclusive. Preserve the independent fingerprint and explicit no-record confirmation, and continue checking the Bails-alpha SHA-256 rule. Update the security model and invariant 4 to document that outcome.

Review shape

Current head fb8d671 is two focused commits directly on refreshed #57 (37eef4d). #57 already contains the reviewed #46 cleanup and #42 correction ancestry, so this PR now shows only the Bails-availability behavior plus its matching security-documentation update.

The runtime commit is patch-identical to the previously reviewed version. The documentation replay preserves the current Core-native seed-source wording from #7/#51 while adding only the reviewed inconclusive-RIPEMD-160 contract. The sole inline review thread is resolved.

Validation

focused identity/no-record tests: 9 passed normally and 9 under python -O;
Ruff check: clean;
strict mypy for the touched Core module: clean;
git diff --check: clean;
exact-head Python-package run 546 (36818915811): success;
exact-head Bitcoin Core wallet-fixture run 11 (36818915778): success.

Human review/integration order is #42 → #46 → #57 → #80 → refreshed #81. After #81 is replayed, rerun the combined early-record/no-record identity regressions and the final full/real-Core gates.

These commits are agent-authored and require the repository's responsible-human review/rewrite or squash policy before merge.

Fixes #79
Refs #30, #46, #57, #81

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ea2ed7093

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BenWestgate

AI-generated release-gate review, posted at the maintainer request. Code ACK 9ea2ed7: the unavailable RIPEMD-160 path now reports an inconclusive standard-Bails check instead of asserting a mismatch; a matching Bails-alpha SHA-256 identifier still wins; and the no-record fingerprint display plus explicit operator confirmation are unchanged. The new frozen-vector regression passes, both current GitHub package matrices are green (12/12 jobs), and the isolated #42/#45/#7/#51/#57/#46 composition plus this commit passes 918 tests at 5,142/5,200 source review lines. No code blocker found. This is not an authorship ACK: the agent-authored commit needs responsible human review and rewrite/squash before merge, and the stack must be refreshed after #7/#57/#46 integration.

BenWestgate

Exact-head release-gate recheck: ACK da14e0d. The prior P1 is resolved: the runtime now distinguishes an unavailable RIPEMD-160 check from a mismatch, still allows the Bails-alpha SHA-256 match to win, and both docs/security/model.md and invariant 4 describe that degraded outcome. git diff --check is clean; the focused identity/identifier tests pass in normal and python -O modes (9/9 each). No additional code blocker found. This remains stacked after #46 and needs the responsible human to review/rewrite or squash the agent-authored commits when the final #57/#46 integration is settled.

BenWestgate · 2026-09-30T20:16:59Z

Agent release-gate re-review at exact head da14e0d: the code commit was already reviewed by Codex; the only later delta is the security-model/invariant wording for the inconclusive RIPEMD-160 case. I reran the focused identifier/restore tests normally and under python -O (9 passed in each mode), and exact-head Python-package run 36753340032 succeeded. The change preserves the independent fingerprint/no-record gate and Bails-alpha SHA-256 check. No remaining code-review blocker found. Keep the planned human rewrite/squash before merge.

Reassign the expected_fingerprint argument instead of copying it into a local, and give existing_secret its None default before the source checks instead of in an else branch. Behavior is unchanged. The installed package drops from 5161 to 5159 logical review lines, which keeps the integrated #7/#42/#57/#46/#80/#81 tip under the <5200 budget. Security: the record gate still runs before any card is generated or shown, and interrupts at that gate still raise _WalletSetupInterrupted. Validation: ruff check, ruff format --check, mypy src/codex32, and pytest (918 passed, with and without -O). Refs #81, #38. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018az69UX4773mYohXAtE8kD

BenWestgate · 2026-10-01T02:18:57Z

AI-assisted release-gate recheck at exact head 0f5f4a8. Code ACK. Both commits are patch-identical to the previously reviewed 9ea2ed7/da14e0d pair: unavailable RIPEMD-160 remains an inconclusive standard-Bails result, Bails-alpha SHA-256 still runs independently, and the explicit fingerprint/no-record gate is unchanged. Exact-head run 36801726820 is green and all review threads are resolved. No code blocker found. Both commits remain Codex Agent-authored and therefore still require responsible-human rewrite/squash when the final #57 → #46 → #80 stack is integrated.

When RIPEMD-160 is unavailable, a valid standard Bails identifier cannot be checked. Preserve the Bails-alpha SHA-256 result and distinguish that inconclusive state from a completed identifier mismatch, so the no-record restore prompt does not claim the cards are wrong. Keep the independent fingerprint and explicit operator-confirmation boundary unchanged. Refs #79

The no-record restore flow can no longer claim a standard Bails identifier mismatch when RIPEMD-160 is unavailable. Record that platform-dependent inconclusive outcome in both the security model and invariant so reviewers can distinguish it from a completed comparison. Refs #79

chatgpt-codex-connector · 2026-10-01T05:15:38Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

BenWestgate

Agent release-gate re-review: ACK fb8d671.

The refreshed runtime patch is unchanged from the reviewed Bails-availability fix, and the documentation conflict resolution preserves the current Core-native seed-source contract while adding the required “RIPEMD-160 unavailable = inconclusive, not mismatch” wording. The sole inline thread is resolved. Exact-head Python-package run 546 and Bitcoin Core wallet-fixture run 11 both succeeded; focused no-record/identity tests also passed normally and under python -O.

No remaining code-review blocker found. Integration/authorship policy remains: #80 follows #57 and its agent-authored commits should be human-reviewed/re-written or squashed before merge.

Reassign the expected_fingerprint argument instead of copying it into a local, and give existing_secret its None default before the source checks instead of in an else branch. Behavior is unchanged. The installed package drops from 5161 to 5159 logical review lines, which keeps the integrated #7/#42/#57/#46/#80/#81 tip under the <5200 budget. Security: the record gate still runs before any card is generated or shown, and interrupts at that gate still raise _WalletSetupInterrupted. Validation: ruff check, ruff format --check, mypy src/codex32, and pytest (918 passed, with and without -O). Refs #81, #38. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018az69UX4773mYohXAtE8kD

BenWestgate added area: cli Command-line interface behavior. area: wallet/core Wallet integration and Bitcoin Core boundaries. bug Something isn't working gate: adversarial review Resolve, merge, or explicitly defer before the next full adversarial review. labels Sep 30, 2026

BenWestgate mentioned this pull request Sep 30, 2026

docs: Prepare the v1 review handoff #38

Open

chatgpt-codex-connector Bot reviewed Sep 30, 2026

View reviewed changes

Comment thread src/codex32/_bitcoin_core.py

BenWestgate mentioned this pull request Sep 30, 2026

Remove pre-review CLI dead code #46

Merged

BenWestgate commented Sep 30, 2026

View reviewed changes

BenWestgate force-pushed the codex/v1-pre-review-cleanup branch from 1899011 to 0793590 Compare October 1, 2026 01:33

BenWestgate force-pushed the codex/restore-inconclusive-ripemd-sep30 branch from da14e0d to 0f5f4a8 Compare October 1, 2026 01:34

BenWestgate mentioned this pull request Oct 1, 2026

cli: Name the real Bitcoin Core requirement when it is missing #84

Open

BenWestgate force-pushed the codex/v1-pre-review-cleanup branch from 0793590 to 0867a1b Compare October 1, 2026 03:01

Codex Agent added 2 commits October 1, 2026 00:14

BenWestgate force-pushed the codex/restore-inconclusive-ripemd-sep30 branch from 0f5f4a8 to fb8d671 Compare October 1, 2026 05:15

BenWestgate changed the base branch from codex/v1-pre-review-cleanup to 30-recorded-fingerprint-gate October 1, 2026 05:16

BenWestgate commented Oct 1, 2026

View reviewed changes

BenWestgate mentioned this pull request Oct 1, 2026

cli: Remove unreachable recovery and search paths #98

Open

Navigation Menu

wallet: Distinguish unavailable Bails checks - #80

wallet: Distinguish unavailable Bails checks#80
BenWestgate wants to merge 2 commits into
30-recorded-fingerprint-gatefrom
codex/restore-inconclusive-ripemd-sep30

BenWestgate commented Sep 30, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

BenWestgate left a comment

Uh oh!

BenWestgate left a comment

Uh oh!

BenWestgate commented Sep 30, 2026

Uh oh!

BenWestgate commented Oct 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 1, 2026

Uh oh!

BenWestgate left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BenWestgate commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Change

Review shape

Validation

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BenWestgate left a comment

Choose a reason for hiding this comment

Uh oh!

BenWestgate left a comment

Choose a reason for hiding this comment

Uh oh!

BenWestgate commented Sep 30, 2026

Uh oh!

BenWestgate commented Oct 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 1, 2026

Uh oh!

BenWestgate left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BenWestgate commented Sep 30, 2026 •

edited

Loading