Skip to content

wallet: Treat unavailable Bails check as inconclusive #79

Description

@BenWestgate

On the no-record restore path, a Python/OpenSSL build without RIPEMD-160 can skip the standard Bails seed-identifier rule. Treat that check as unavailable/inconclusive rather than telling the operator that otherwise valid cards are wrong or mixed up. Preserve the SHA-256 Bails-alpha check and the independent fingerprint/no-record confirmation gate.

Implemented and reviewed in focused PR #80. The current head fb8d671 is refreshed directly onto #57 (37eef4d) and therefore already carries the #42 → #46 → #57 ancestry. The runtime commit is patch-identical to the reviewed version; the documentation replay preserves #7/#51's current Core-native seed-source wording while adding only the inconclusive-RIPEMD-160 contract. The sole inline review thread is resolved.

Current exact-head validation for #80:

  • focused identity/no-record tests: 9 passed normally and 9 under python -O;
  • Ruff check: clean;
  • strict mypy for the touched Core module: clean;
  • git diff --check: clean;
  • Python-package run 36818915811: success;
  • Bitcoin Core wallet-fixture run 36818915778: success.

Keep this issue open until the final replay order lands on the settled candidate: #42 → #46 → #57 → #80 → #81. #81 must be refreshed directly onto #80; then rerun the identifier/no-record regressions together with #81's early record-gate tests, the real-Core fixtures, full CI and review-thread audit. #80 is agent-authored and requires the repository's responsible-human review/rewrite-squash policy before merge.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: cliCommand-line interface behavior.area: wallet/coreWallet integration and Bitcoin Core boundaries.bugSomething isn't workinggate: adversarial reviewResolve, merge, or explicitly defer before the next full adversarial review.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions