Repository navigation
fix(ci): preserve optional platform brokers in lockfile - #2134
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Independent exact-head review signoff for Base reproduction under exact CI Node/npm: At the reviewed head: Both clean installs contain only Release-style npm 11.19.1 resolution regenerates the intended durable classifications: Relevant tests and scope: The root is private; no published package manifest changes. Existing release logic keeps the harness/broker compatibility closure frozen at 17.2.1 and does not publish those packages. This repairs npm 10/11 lock interpretation without reviving broker runtime/publication work or changing any gate. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] This PR appears safe to merge.
|
AgentRelayBot
left a comment
There was a problem hiding this comment.
Independent exact-head approval for 475940c. Base npm 10.9.2 clean install reproduces EBADPLATFORM; this head passes npm 10.9.2 and 11.19.1 clean installs. Most importantly, after removing package-lock.json, a release-style npm 11.19.1 Linux/x64 package-lock-only resolution is byte-for-byte identical to the committed lock: harness-driver 17.2.1 is devOptional and all five brokers are optional, with no extraneous records. Focused publish/peer tests are 66/66, full hosted matrix is terminal green/neutral/skipped, diff check is clean, and unresolved review threads are zero. This is the durable repair; competing PR 2135 must remain held/superseded.
Summary
This is intentionally a two-file manifest/lock repair. It does not change workflows, gates, package versions, or dependency versions. It unblocks the Linux install failure affecting core-bridge PR #2133. No changelog entry: this corrects internal installation metadata without a user-visible Relay behavior change.
Root cause
The v18.0.0 release fresh resolution selected @agent-relay/harness-driver 17.2.1 for the optional @relayflows/sdk peer through the existing override, but npm 11 wrote that peer and its platform brokers as extraneous. npm 10.9.2 therefore treated every broker as mandatory and failed on Linux when it reached broker-darwin-arm64. Making the already-selected dev peer explicit gives npm 11 the dependency edge it needs; the regenerated lock records the harness as devOptional and each broker as optional.
Exact base failure
Exact repaired-head verification
Release-resolver reproducibility:
Lock closure after regeneration:
Additional checks:
Known unrelated validation: npm run syncpack still exits nonzero on the exact base and repaired head for existing @types/node, tar, and typescript version-group drift. This PR does not alter those packages.
Test Plan
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.