Repository navigation
Fix clean installs after retiring platform broker packages - #2135
khaliqgant wants to merge 2 commits into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Blocking durability finding at exact 3ec54bf. The committed pruned lock installs, but the publish workflow does not reuse it: Clean reinstall after version bump deletes package-lock.json and runs npm 11.19.1 install. Reproducing that fresh resolution from this head with Linux/x64 targeting recreates the original broken records: node v26.9.0; npm 11.19.1 @agent-relay/harness-driver 17.2.1: extraneous=true A package-lock-only reconciliation with the committed lock present is not sufficient evidence; only the fresh no-lock resolution matches publish.yml lines 495-496. On the next release, this PR alone would regenerate the same mandatory cross-platform nodes and commit them again. Please do not merge #2135 as the durable fix. The manifest-edge approach in draft #2134 is directionally correct because it makes the frozen harness an explicit root dev edge and causes fresh npm 11 resolution to classify the harness devOptional and brokers optional. Select one canonical repair, include a regression that deletes the lock and performs the release-style fresh resolution, and close/supersede the other PR. |
Clean installs fail with
EBADPLATFORMbecause the npm lockfile still contains platform broker packages retired from the workspace. Regenerate the lockfile with CI’s npm 10.9.2 so those unused packages disappear while required optional peer adapters remain resolvable.The final delta removes six extraneous broker/harness records and updates generated optional/peer/libc metadata. Every retained package version, resolved URL, integrity value and dependency specification matches main; no manifest or runtime code changes.
Validation:
1db553041Test run 42716346786 and Factory run 42719056583 reproduce the Darwin/ARM64 package refusal.The initial local-only prune exposed an older-npm peer-resolution failure in CI; the final regeneration corrects it. The earlier dry run was nondiscriminating and is not installation proof. No provider, service, model or release operation is involved.