-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: enable r8 minification #2891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RohitKushvaha01
merged 1 commit into
Acode-Foundation:main
from
RohitKushvaha01:enable_r8
Sep 15, 2026
+41
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Keep Cordova classes | ||
| -keep class org.apache.cordova.** { *; } | ||
|
|
||
| # Cordova discovers plugins by class name from config.xml and instantiates them | ||
| # reflectively, and plugins can dispatch actions by method name through | ||
| # reflection too (e.g. Ftp.execute() uses | ||
| # getClass().getDeclaredMethod(action, JSONArray, CallbackContext)). | ||
| # Without keeping the members, R8 strips methods such as connect()/listDirectory() | ||
| # and those plugin calls fail at runtime with NoSuchMethodException. | ||
| -keep public class * extends org.apache.cordova.CordovaPlugin { *; } | ||
|
|
||
| # WebView JS bridge methods are invoked by name from JavaScript. | ||
| -keepclassmembers class * { | ||
| @android.webkit.JavascriptInterface <methods>; | ||
| } | ||
|
|
||
| # cordova-plugin-buildinfo resolves the app's BuildConfig reflectively: | ||
| # Class.forName(packageName + ".BuildConfig") and c.getField(fieldName). | ||
| -keep class **.BuildConfig { *; } | ||
|
|
||
| # maverick-synergy (SSH/SFTP) references java.lang.management from | ||
| # Utils.generateThreadDump(), which does not exist on Android. That method is | ||
| # never reached on Android, so ignore the missing Java SE classes. | ||
| -dontwarn java.lang.management.** | ||
|
|
||
| # Keep Javascript Interface attributes | ||
| -keepattributes *Annotation*,EnclosingMethod,InnerClasses,Signature |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.