Skip to content

feat: enable r8 minification - #2891

Merged
RohitKushvaha01 merged 1 commit into
Acode-Foundation:mainfrom
RohitKushvaha01:enable_r8
Sep 15, 2026
Merged

RohitKushvaha01 merged 1 commit into
Acode-Foundation:mainfrom
RohitKushvaha01:enable_r8

Conversation

@RohitKushvaha01

@RohitKushvaha01 RohitKushvaha01 commented Sep 13, 2026

Copy link
Copy Markdown
Member

Closes #2889

Note: after r8 is enabled every release must be tested for ClassNotFoundException and every new library/java class must be registered in proguard rules files

@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with the non-blocking concern that release-only minification behavior lacks automated validation.

Findings

  1. P2 Release Minification Lacks Coverage

Summary

  • Copies the Gradle and ProGuard configuration into Cordova’s Android app module.
  • Preserves application-owned reflection paths identified in Cordova plugins.
  • Would benefit from automated minified-release coverage to catch future retention gaps.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Cordova prepare] --> B[Copy build-extras.gradle]
  A --> C[Copy proguard-rules.pro]
  B --> D[Android release build]
  C --> D
  D --> E[R8 code optimization]
  D --> F[Android resource shrinking]
  E --> G[Apply Cordova and reflection keep rules]
  G --> H[Release APK]
  F --> H
Loading

Reviews (1) · Last reviewed commit: "feat: enable r8 minification"

Comment thread build-extras.gradle
@RohitKushvaha01 RohitKushvaha01 moved this from Backlog to Done in The Code Board - Acode Sep 13, 2026
@RohitKushvaha01
RohitKushvaha01 added this pull request to the merge queue Sep 15, 2026
Merged via the queue into Acode-Foundation:main with commit 428395f Sep 15, 2026
6 checks passed
@RohitKushvaha01
RohitKushvaha01 deleted the enable_r8 branch September 15, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

DEX code optimization is below our threshold

1 participant