Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transcript-only clients currently pass
nullptrto the native SDK even when transcript parameters have been configured. This change includes transcript parameters in the configuration check so that explicit language and language identification settings reach the SDK.It also releases the allocated transcript parameters after configuration, following the existing cleanup for audio, video, and deskshare parameters.
Related Issues
Fixes #133
Type of Change
Affected Components
Testing Performed
Updated the existing C++ regression test to verify the transcript parameters received by the mock native SDK. It covers configuration before callback registration, after registration but before joining, and after joining. Each case checks that the client requests only transcripts and passes the configured parameter values. All three cases failed before the fix and passed afterward.
task doctor: passed; required tools and the darwin-arm64 SDK were available.RTMS_BUILD_TESTS=ON.task test:local: both bindings built successfully; all 98 Node.js tests and 122 Python tests passed.git diff --check: passed.Commands to reproduce the checks:
Checklist