Skip to content

fix: preserve transcript parameters for transcript-only clients - #134

Open
ponharu wants to merge 1 commit into
zoom:mainfrom
ponharu:fix/transcript-only-parameters
Open

ponharu wants to merge 1 commit into
zoom:mainfrom
ponharu:fix/transcript-only-parameters

Conversation

@ponharu

@ponharu ponharu commented Oct 8, 2026 •

Copy link
Copy Markdown

Description

Transcript-only clients currently pass nullptr to the native SDK even when transcript parameters have been configured. This change includes transcript parameters in the configuration check so that explicit language and language identification settings reach the SDK.

It also releases the allocated transcript parameters after configuration, following the existing cleanup for audio, video, and deskshare parameters.

Related Issues

Fixes #133

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Tests (adding or improving tests)
  • Build changes

Affected Components

  • Core C++ implementation
  • Node.js bindings
  • Python bindings
  • Go bindings
  • Build system
  • Documentation
  • Examples
  • Other (please specify)

Testing Performed

Updated the existing C++ regression test to verify the transcript parameters received by the mock native SDK. It covers configuration before callback registration, after registration but before joining, and after joining. Each case checks that the client requests only transcripts and passes the configured parameter values. All three cases failed before the fix and passed afterward.

  • task doctor: passed; required tools and the darwin-arm64 SDK were available.
  • C++ tests: all 70 passed in a Debug build with RTMS_BUILD_TESTS=ON.
  • task test:local: both bindings built successfully; all 98 Node.js tests and 122 Python tests passed.
  • git diff --check: passed.

Commands to reproduce the checks:

task doctor
task test:local
cmake -B .tmp/build/tests -DRTMS_BUILD_TESTS=ON -DCMAKE_BUILD_TYPE=Debug
cmake --build .tmp/build/tests --target rtms_tests
ctest --test-dir .tmp/build/tests --output-on-failure

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas (not applicable)
  • I have made corresponding changes to the documentation (not applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published (not applicable)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Transcript-only clients ignore configured transcript parameters

1 participant