Skip to content

Fix retention offer prices continuation query and compound emoji validation - #39

Merged
zelentsov-dev merged 1 commit into
developfrom
bugs/retention-prices-continuation-emoji
Nov 7, 2026
Merged

zelentsov-dev merged 1 commit into
developfrom
bugs/retention-prices-continuation-emoji

Conversation

@zelentsov-dev

Copy link
Copy Markdown
Owner

Summary

  • Preserve canonical include=territory,subscriptionPricePoint and fields[...] query parameters on subscriptions_list_retention_offer_prices continuation requests (next_url), even when the caller supplies a minimal continuation link (/v1/retentionOffers/{id}/prices?cursor=...), while keeping validatedScopedLink tampering checks prior to network I/O.
  • Reject compound emoji sequences using Variation Selector-16 (U+FE0F) or Combining Enclosing Keycap (U+20E3) such as 1️⃣, #️⃣, *️⃣, ©️, ®️, and ™️ in ASCMetadataValidator.containsEmoji, while continuing to accept plain ASCII/BMP text symbols (1, ©, ®, ™) and Plane 2 CJK Unified Ideographs (U+20BB7, U+20B9F).
  • Add regression assertions verifying continuation query parameters and projected price fields (customerPrice, proceeds, proceedsYear2, currency) as well as compound emoji rejection before HTTP I/O.

@zelentsov-dev

Copy link
Copy Markdown
Owner Author
Protocol: DX-REVIEW/1
Message: REVIEW_RESULT
Round: 1
Repository: zelentsov-dev/asc-mcp
PR: 39
Base-SHA: 2850deee12105fac709dbb9e20605dc35401bb6a
Head-SHA: 96abcfefc39eff00de55522edb499a2bd36dabd0
Previous-Reviewed-Head: N/A
Delta: 2850deee12105fac709dbb9e20605dc35401bb6a...96abcfefc39eff00de55522edb499a2bd36dabd0
Change-Class: bugfix
Deployment-Authority: no-deploy

## Findings
P0-P3: none

## Verdict
- Patch: APPROVE
- Merge: READY
- Merge-Actor: TEAMLEAD
- Release-Deploy: NOT_ASSESSED
- Production-Authority: OWNER_ONLY
- Approved-Head: 96abcfefc39eff00de55522edb499a2bd36dabd0
- CI: green (Promotion Lineage, Tests, Latest Apple Contract Drift, Release & Apple Contract)
- Remaining-Not-Checked: Live App Store Connect API pagination continuation against production tenant

@zelentsov-dev
zelentsov-dev merged commit f7ddc21 into develop Nov 7, 2026
5 checks passed
@zelentsov-dev
zelentsov-dev deleted the bugs/retention-prices-continuation-emoji branch November 7, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant