Repository navigation
fix(subscriptions): fix retention next_url pagination, offer price projection, and Plane 2 CJK validation - #38
Merged
Conversation
…er price amounts, and allow Plane 2 CJK copy
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next_urlpagination across all 6 retention list handlers (subscriptions_list_retention_messages,subscriptions_list_retention_message_versions,subscriptions_list_retention_message_localizations,subscriptions_list_retention_message_subscriptions,subscriptions_list_retention_offers,subscriptions_list_retention_offer_prices) throughhttpClient.getPage(nextURL, scope: pagination.scope, as: ...)so both absolute configured-origin URLs and root-relative URLs succeed while enforcing exact path, cursor, limit, and territory filter scope.include=territory,subscriptionPricePointand related field sets insubscriptions_list_retention_offer_pricesand projectcurrency,customerPrice/customer_price,proceeds,proceedsYear2/proceeds_year2,territoryId/territory_id, andsubscriptionPricePointId/subscription_price_point_id/price_point_id.validateNoEmojiin retention handlers toASCMetadataValidator.containsEmojiso Plane 2 CJK Unified Ideographs Extension B+ characters (such asU+20BB7andU+20B9F) are accepted while actual emojis remain rejected before network I/O.#if DEBUGprintstatements inJWTService.swiftto&standardErrorto preserve JSON-RPC stdio hygiene in debug builds.RetentionMessagingContractTestscovering all 14 pagination combinations, negative scope rejections, price amount/currency projection, and Plane 2 CJK vs emoji validation.Verification
swift test(1991 tests in 153 suites passed)swift build -c release.build/release/asc-mcp openapi-contract-check --spec Tests/ASCMCPTests/Fixtures/OpenAPI/app-store-connect-4.6.oas.json --strict(0 structural errors, 0 implementation drift)python3 -B .github/workflows/scripts/assets_mcp_smoke.py --binary .build/release/asc-mcpand--binary .build/debug/asc-mcp(both passed)