Conversation
…is and series metadata - getLabels() reads attributes.ome.labels for zarr v3 labels groups (spec 0.5/0.6), falling back to the legacy attributes.labels; fix the v0.5 labels fixture to the spec layout. - Axis serializes longName (spec) and still accepts long_name on read. - displacements/coordinates transforms keep their interpolation field. - Model labels, image-label and series in the v0.5 and v0.6 OmeMetadata (new shared ImageLabel type; unknown keys in colors/properties are kept). createScaleLevel no longer drops ome fields in v0.5. - Add the projectAxis transform (droppedInputs/createdOutputs). - byDimension items use inputAxes/outputAxes, accepting the snake_case aliases on read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unmodelled OME fields were dropped on read, so opening and saving a file lost them. This PR models them and fixes where
labelsis read from.Changes
getLabels(): readsattributes.ome.labels(spec, 0.5/0.6); still accepts the legacyattributes.labels. The v0.5 labels fixture is fixed to the spec layout.longName: written aslongName;long_namestill accepted on read.interpolationondisplacements/coordinates: now kept.labels,image-label,series: added to v0.5 and v0.6OmeMetadata(new sharedImageLabelwithcolors,properties,source).projectAxis: new transform class (droppedInputs,createdOutputs).byDimension:inputAxes/outputAxesare canonical; snake_case still accepted.createScaleLevel(v0.5/v0.6) no longer dropsomero,bioformats2raw.layoutand the new fields.Tests
Round-trip tests (read spec JSON → write → compare trees) for all of the above.
mvn test -Dtest='OmeZarr*Test,OmeObjectMappersTest': 88 tests, 0 failures.Related: #110 (coordinate system references as
{name, path}). Whichever merges second needs a small rebase.🤖 Generated with Claude Code