Skip to content

ci: run zsh-lint v1.6.1 in the observe-mode workflow - #664

Merged
ss-o merged 1 commit into
mainfrom
feature-663-zsh-lint-v1-6-1
Oct 25, 2026
Merged

ss-o merged 1 commit into
mainfrom
feature-663-zsh-lint-v1-6-1

Conversation

@ss-o

@ss-o ss-o commented Oct 25, 2026

Copy link
Copy Markdown
Member

Description

Pin the advisory zsh-lint workflow to the published v1.6.1 release: zsh-lint-ref in .github/workflows/zsh-lint.yml moves from f6341241c398fd2a784452e75895dafb06186bbc # v1.6.0 to 136df813e37d0ec48573929489b44c1841af57ee # v1.6.1 (z-shell/zsh-lint#751). The paths, zsh-lint.json and observe mode are unchanged, and no Zi source changes.

The pinned commit is the v1.6.1 tag commit and is on z-shell/zsh-lint main.

Findings against v1.6.0

The organization runner (automation/ci/zsh_lint_ci.py), in observe mode with zsh-lint.json and the workflow's 11 literal paths, at main ae2dc8e and on this branch:

Analyzer Files Parser errors Errors Warnings Info Hint Result
v1.6.0 17 0 0 0 192 4 passed
v1.6.1 17 0 0 0 192 4 passed

Every finding keeps its file, position, rule and severity. One message changes: quoting/unquoted-var at zi.zsh:3040:40, on the single-element $___opt_map[$cmd], now gives scalar advice instead of suggesting "${___opt_map[@]}" (z-shell/zsh-lint#747).

Related issues

Closes #663

Type of change

  • fix: bug fix (non-breaking)
  • feat: new feature (non-breaking)
  • feat! / fix!: breaking change
  • perf: performance improvement
  • refactor: code change with no functional impact
  • docs: documentation only
  • test: test addition or correction
  • build: build system or dependency change
  • ci: CI/workflow change
  • style: formatting with no behavior change
  • chore: maintenance / dependency bump
  • revert: revert of an earlier change

Checklist

  • Work branches from current main and targets protected main
  • Full stable qualification passes on the current candidate; release authority is separate
  • Commit messages follow Conventional Commits format
  • I have read the contribution guidelines
  • Native syntax/compilation and affected functional regressions pass; exact commands and compatibility limits are recorded
  • Non-obvious Zsh behavior is checked against the organization scripting standard and relevant official manual sections
  • Documentation updated if needed

Verification: the runner comparison above with zsh-lint built from 136df81; trunk check and actionlint on the workflow pass. No Zsh source changes; the native syntax, compilation and functional suites are the Promotion gate's on this pull request. No documentation refers to the pinned version.

Pin the advisory zsh-lint workflow to the published v1.6.1 release
(136df813e37d0ec48573929489b44c1841af57ee). Paths, configuration and
observe mode are unchanged.

Closes #663
@ss-o ss-o moved this to In Review in Z-shell Delivery Oct 25, 2026

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on 47e9705

Findings

No actionable findings.

Scope: the complete diff from main at ae2dc8e to 47e9705: one line, .github/workflows/zsh-lint.yml:56, against the acceptance criteria of #663. The Copilot request on this head (2026-10-25T00:43:56Z) produced no review_requested event for Copilot; cause unconfirmed.

Note

This is a maintainer-elected fallback review, not an independent review or an approval to merge.

Validation

  • Passed on the head: all 31 pull-request checks, including the Promotion gate and the Configured Zsh Lint job on the new pin. No review threads are open.
  • Reproduced for this review: zsh-lint built from the v1.6.1 source and the organization runner (automation/ci/zsh_lint_ci.py) run on the head with the workflow's own 11 paths, zsh-lint.json and observe mode: 17 files, 0 parser errors, 0 errors, 0 warnings, 192 info and 4 hint findings, passed. The diagnostics equal a v1.6.1 run at main; against v1.6.0 only the quoting/unquoted-var message at zi.zsh:3040:40 changes, with every file, range, rule and severity identical. actionlint on the workflow passes.
  • Not part of this change: Zsh sources, commands, loading and installation paths are untouched; the native and platform suites are covered by the green Promotion gate.
Checklist verdicts and supporting evidence
  • Pin provenance: pass. 136df813e37d0ec48573929489b44c1841af57ee is the commit of the signed v1.6.1 tag of z-shell/zsh-lint and is on its main; the # v1.6.1 comment matches. It replaces the v1.6.0 tag commit f6341241c398fd2a784452e75895dafb06186bbc.
  • Workflow contract: pass. Name, job, triggers, contents: read permissions, caller-owned concurrency, the organization reusable workflow at @main, paths, configuration and observe mode are unchanged.
  • Ref consumption and failure paths: pass. The reusable workflow validates the ref as a 40-character SHA, checks out z-shell/zsh-lint at it without persisted credentials, builds ./cmd/zsh-lint with the Go version from its go.mod, and the runner fails on parser errors, configuration errors, unexpected exit codes or malformed reports even in observe mode. v1.6.0 and v1.6.1 have identical go.mod, go.sum and CLI entry point.
  • Behaviour for this repository: pass. Same counts and result as v1.6.0; one advice message changes. The check stays outside the Promotion gate.
  • Zi runtime contracts: not applicable. No public command, ice, loading, unloading or update behaviour changes.
  • Traceability: pass. The body closes #663, the branch is feature-663-zsh-lint-v1-6-1 and the title follows Conventional Commits.

Limits

  • The v1.6.0 comparison uses the run at main; the head changes no Zsh source.

@ss-o
ss-o merged commit 5d095f6 into main Oct 25, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in Z-shell Delivery Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[chore]: run zsh-lint v1.6.1 in the observe-mode workflow

1 participant