Repository navigation
ci: run zsh-lint v1.6.1 in the observe-mode workflow - #664
Merged
Merged
Conversation
Pin the advisory zsh-lint workflow to the published v1.6.1 release (136df813e37d0ec48573929489b44c1841af57ee). Paths, configuration and observe mode are unchanged. Closes #663
ss-o
commented
Oct 25, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 47e9705
Findings
No actionable findings.
Scope: the complete diff from main at ae2dc8e to 47e9705: one line, .github/workflows/zsh-lint.yml:56, against the acceptance criteria of #663. The Copilot request on this head (2026-10-25T00:43:56Z) produced no review_requested event for Copilot; cause unconfirmed.
Note
This is a maintainer-elected fallback review, not an independent review or an approval to merge.
Validation
- Passed on the head: all 31 pull-request checks, including the Promotion gate and the Configured Zsh Lint job on the new pin. No review threads are open.
- Reproduced for this review: zsh-lint built from the
v1.6.1source and the organization runner (automation/ci/zsh_lint_ci.py) run on the head with the workflow's own 11 paths,zsh-lint.jsonand observe mode: 17 files, 0 parser errors, 0 errors, 0 warnings, 192 info and 4 hint findings, passed. The diagnostics equal a v1.6.1 run atmain; against v1.6.0 only thequoting/unquoted-varmessage atzi.zsh:3040:40changes, with every file, range, rule and severity identical.actionlinton the workflow passes. - Not part of this change: Zsh sources, commands, loading and installation paths are untouched; the native and platform suites are covered by the green Promotion gate.
Checklist verdicts and supporting evidence
- Pin provenance: pass.
136df813e37d0ec48573929489b44c1841af57eeis the commit of the signedv1.6.1tag of z-shell/zsh-lint and is on itsmain; the# v1.6.1comment matches. It replaces thev1.6.0tag commitf6341241c398fd2a784452e75895dafb06186bbc. - Workflow contract: pass. Name, job, triggers,
contents: readpermissions, caller-owned concurrency, the organization reusable workflow at@main, paths, configuration and observe mode are unchanged. - Ref consumption and failure paths: pass. The reusable workflow validates the ref as a 40-character SHA, checks out
z-shell/zsh-lintat it without persisted credentials, builds./cmd/zsh-lintwith the Go version from itsgo.mod, and the runner fails on parser errors, configuration errors, unexpected exit codes or malformed reports even in observe mode.v1.6.0andv1.6.1have identicalgo.mod,go.sumand CLI entry point. - Behaviour for this repository: pass. Same counts and result as
v1.6.0; one advice message changes. The check stays outside the Promotion gate. - Zi runtime contracts: not applicable. No public command, ice, loading, unloading or update behaviour changes.
- Traceability: pass. The body closes #663, the branch is
feature-663-zsh-lint-v1-6-1and the title follows Conventional Commits.
Limits
- The
v1.6.0comparison uses the run atmain; the head changes no Zsh source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pin the advisory zsh-lint workflow to the published v1.6.1 release:
zsh-lint-refin.github/workflows/zsh-lint.ymlmoves fromf6341241c398fd2a784452e75895dafb06186bbc # v1.6.0to136df813e37d0ec48573929489b44c1841af57ee # v1.6.1(z-shell/zsh-lint#751). The paths,zsh-lint.jsonand observe mode are unchanged, and no Zi source changes.The pinned commit is the
v1.6.1tag commit and is on z-shell/zsh-lintmain.Findings against v1.6.0
The organization runner (
automation/ci/zsh_lint_ci.py), in observe mode withzsh-lint.jsonand the workflow's 11 literal paths, atmainae2dc8e and on this branch:Every finding keeps its file, position, rule and severity. One message changes:
quoting/unquoted-varatzi.zsh:3040:40, on the single-element$___opt_map[$cmd], now gives scalar advice instead of suggesting"${___opt_map[@]}"(z-shell/zsh-lint#747).Related issues
Closes #663
Type of change
fix: bug fix (non-breaking)feat: new feature (non-breaking)feat!/fix!: breaking changeperf: performance improvementrefactor: code change with no functional impactdocs: documentation onlytest: test addition or correctionbuild: build system or dependency changeci: CI/workflow changestyle: formatting with no behavior changechore: maintenance / dependency bumprevert: revert of an earlier changeChecklist
mainand targets protectedmainVerification: the runner comparison above with zsh-lint built from
136df81;trunk checkandactionlinton the workflow pass. No Zsh source changes; the native syntax, compilation and functional suites are the Promotion gate's on this pull request. No documentation refers to the pinned version.