Repository navigation
fix: 修复 TUI 通知列表溢出顶掉顶部状态 - #37
Merged
Merged
Conversation
[Low impact] The changes affect only the CodexMonitor terminal display. The short-terminal overflow should be fixed before merging. Findings
SummaryCollapses notification messages to one line and limits the visible list using terminal height.
Reviews (1) · Last reviewed commit: "fix: 修复 TUI 通知列表溢出顶掉顶部状态" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概述
修复 TUI 通知列表在多行消息较多时把顶部额度、网络状态顶出屏幕的问题。
根因
NotificationList的MAX_ROWS = 6限制的是“6 条通知”,不是“6 行”wrap="truncate"只按宽度截断,不折叠换行rows做高度约束改动
NotificationList新增maxRows,按可见条数裁剪App读取终端rows,扣除头部/额度面板/边框/快捷键后计算maxRowsApp新增测试用rows注入验证
maxRows裁剪、终端高度不足时总行数不超屏npm run typecheck通过npm test:319 通过 + 1 跳过(320)说明
Closes #36